Batch loading sometimes missing a records #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If sink task write gcs file in parallel, gcs filename is dupulicated currently. gcs filename added first offset for unique file name If sink task write gcs file in same folder, other process delete other tables gcs file. so seperated folder for tables
If sink task write gcs file in parallel, gcs filename is dupulicated currently. gcs filename added first offset for unique file name If sink task write gcs file in same folder, other process delete other tables gcs file. so seperated folder for tables waiting job status for bigquery load job adding log for job's suceeded rows count
|
Hey @jeonguihyeong could you reformulate your PR text , it's very complicate to understand your message , thanks |
devinay
reviewed
Apr 12, 2022
| @@ -247,7 +249,8 @@ public void put(Collection<SinkRecord> records) { | |||
| TableWriterBuilder tableWriterBuilder; | |||
| if (config.getList(BigQuerySinkConfig.ENABLE_BATCH_CONFIG).contains(record.topic())) { | |||
| String topic = record.topic(); | |||
| String gcsBlobName = topic + "_" + uuid + "_" + Instant.now().toEpochMilli(); | |||
| long offset = record.kafkaOffset(); | |||
| String gcsBlobName = topic + "_" + uuid + "_" + Instant.now().toEpochMilli()+"_"+records.size()+"_"+offset; | |||
There was a problem hiding this comment.
Would having a test case for validating that parallel puts create different files with the right offset help?
There was a problem hiding this comment.
gcp side
- you can use gcs versioning and how many times write gcs name.
bigquery sink
- it's concept is used s3 sink. i convert to bigquery sink.
it is using first offset of records. and it is not corrupted because kafka message offset is unique.
if you need more comment, connect me.
|
We have not been able to reproduce missing records issue on our end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If sink task write gcs file in parallel, gcs filename is dupulicated currently.
gcs filename added first offset for unique file name
If sink task write gcs file in same folder, other process delete other tables gcs file.
so seperated folder for tables
waiting job status for bigquery load job
adding log for job's suceeded rows count
Update GCSToBQLoadRunnable.java
If sink task write gcs file in parallel, gcs filename is dupulicated currently.
gcs filename added first offset for unique file name
If sink task write gcs file in same folder, other process delete other tables gcs file.
so seperated folder for tables
waiting job status for bigquery load job
adding log for job's suceeded rows count
Update BigQuerySinkTask.java
If sink task write gcs file in parallel, gcs filename is dupulicated currently.
gcs filename added first offset for unique file name
If sink task write gcs file in same folder, other process delete other tables gcs file.
so seperated folder for tables