Skip to content

Commit

Permalink
GH-264: Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Nigel Liang <[email protected]>
  • Loading branch information
C0urante and ncliang committed Sep 10, 2020
1 parent 69c46fd commit d8aae10
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ public class BigQuerySinkConfig extends AbstractConfig {
private static final ConfigDef.Type INTERMEDIATE_TABLE_SUFFIX_TYPE = ConfigDef.Type.STRING;
public static final String INTERMEDIATE_TABLE_SUFFIX_DEFAULT = "tmp";
private static final ConfigDef.Validator INTERMEDIATE_TABLE_SUFFIX_VALIDATOR = new ConfigDef.NonEmptyString();
private static final ConfigDef.Importance INTERMEDIATE_TTABLE_SUFFIX_IMPORTANCE = ConfigDef.Importance.LOW;
private static final ConfigDef.Importance INTERMEDIATE_TABLE_SUFFIX_IMPORTANCE = ConfigDef.Importance.LOW;
private static final String INTERMEDIATE_TABLE_SUFFIX_DOC =
"A suffix that will be appended to the names of destination tables to create the names for "
+ "the corresponding intermediate tables. Multiple intermediate tables may be created for a "
Expand Down Expand Up @@ -452,7 +452,7 @@ public static ConfigDef getConfig() {
INTERMEDIATE_TABLE_SUFFIX_TYPE,
INTERMEDIATE_TABLE_SUFFIX_DEFAULT,
INTERMEDIATE_TABLE_SUFFIX_VALIDATOR,
INTERMEDIATE_TTABLE_SUFFIX_IMPORTANCE,
INTERMEDIATE_TABLE_SUFFIX_IMPORTANCE,
INTERMEDIATE_TABLE_SUFFIX_DOC
).define(
MERGE_INTERVAL_MS_CONFIG,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@


import com.wepay.kafka.connect.bigquery.config.BigQuerySinkConfig;
import com.wepay.kafka.connect.bigquery.config.BigQuerySinkTaskConfig;

import java.util.HashMap;
import java.util.Map;
Expand Down

0 comments on commit d8aae10

Please sign in to comment.