Skip to content

Migrate from NAN -> NAPI #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
+3,438 −3,478
Draft

Migrate from NAN -> NAPI #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e2264c2
🚏 run nan -> napi migration script
cowboyd Mar 25, 2025
18bc36d
"fix" header files
cowboyd Mar 25, 2025
957c9e5
upgrade bindings.cc and constants entry point
cowboyd Mar 25, 2025
b1f432b
Move connection into template
cowboyd Mar 25, 2025
58c78d1
fix ErrorAwareWorker
cowboyd Mar 25, 2025
e23e5f2
add back static setOauthBearerFailure method
cowboyd Mar 25, 2025
548443e
Sort out error problems
cowboyd Mar 26, 2025
2dbfe79
Finish converting KafkaConsumer
cowboyd Mar 26, 2025
bba76c9
producer: NAN -> N-API
cowboyd Mar 26, 2025
0ac2c22
admin client NAN -> NAPI
cowboyd Mar 26, 2025
ecc9be5
Topic NAN -> NAPI
cowboyd Mar 26, 2025
acd8c4a
Fixup connection
cowboyd Mar 26, 2025
a329109
Fix header file ordering
cowboyd Mar 26, 2025
76668f7
cleanup whitespace
cowboyd Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@
"targets": [
{
"target_name": "confluent-kafka-javascript",
"cflags!": [ "-fno-exceptions" ],
"cflags_cc!": [ "-fno-exceptions" ],
"xcode_settings": { "GCC_ENABLE_CPP_EXCEPTIONS": "YES",
"CLANG_CXX_LIBRARY": "libc++",
"MACOSX_DEPLOYMENT_TARGET": "10.7",
},
"msvs_settings": {
"VCCLCompilerTool": { "ExceptionHandling": 1 },
},
'sources': [
'src/binding.cc',
'src/callbacks.cc',
Expand All @@ -22,7 +31,7 @@
'src/admin.cc'
],
"include_dirs": [
"<!(node -e \"require('nan')\")",
"<!(node -p \"require('node-addon-api').include_dir\")",
"<(module_root_dir)/"
],
'conditions': [
Expand Down Expand Up @@ -70,6 +79,7 @@
}
},
'include_dirs': [
'<!(node -p "require(\'node-addon-api\').include_dir")',
'deps/include'
]
},
Expand All @@ -81,6 +91,7 @@
"deps/librdkafka.gyp:librdkafka"
],
"include_dirs": [
"<!(node -p \"require('node-addon-api').include_dir\")",
"deps/librdkafka/src",
"deps/librdkafka/src-cpp"
],
Expand Down Expand Up @@ -125,6 +136,7 @@
{
"libraries": ["-lrdkafka", "-lrdkafka++"],
"include_dirs": [
"<!(node -p \"require('node-addon-api').include_dir\")",
"/usr/include/librdkafka",
"/usr/local/include/librdkafka",
"/opt/include/librdkafka",
Expand Down
1 change: 1 addition & 0 deletions examples/kafkajs/oauthbearer_calback_authentication/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"author": "",
"license": "ISC",
"dependencies": {
"node-addon-api": "8.3.1",
"@confluentinc/kafka-javascript": "file:../../..",
"jsonwebtoken": "^9.0.2"
}
Expand Down
1 change: 1 addition & 0 deletions examples/node-rdkafka/oauthbearer_callback_authentication/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"author": "",
"license": "MIT",
"dependencies": {
"node-addon-api": "8.3.1",
"@confluentinc/kafka-javascript": "file:../../..",
"jsonwebtoken": "^9.0.2"
}
Expand Down
1 change: 1 addition & 0 deletions examples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"author": "",
"license": "MIT",
"dependencies": {
"node-addon-api": "8.3.1",
"@confluentinc/kafka-javascript": "file:.."
}
}
1 change: 1 addition & 0 deletions examples/performance/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"license": "ISC",
"description": "",
"dependencies": {
"node-addon-api": "8.3.1",
"@confluentinc/kafka-javascript": "file:../..",
"kafkajs": "^2.2.4"
}
Expand Down
1 change: 1 addition & 0 deletions examples/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"author": "",
"license": "MIT",
"dependencies": {
"node-addon-api": "8.3.1",
"@confluentinc/kafka-javascript": "file:../..",
"typescript": "^5.4.4"
},
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@
"typescript-eslint": "^8.2.0"
},
"dependencies": {
"node-addon-api": "8.3.1",
"@mapbox/node-pre-gyp": "^1.0.11",
"bindings": "^1.3.1",
"nan": "^2.22.0"
"bindings": "^1.3.1"
},
"engines": {
"node": ">=18.0.0"
Expand All @@ -65,4 +65,4 @@
"schemaregistry",
"schemaregistry-examples"
]
}
}
1 change: 1 addition & 0 deletions schemaregistry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"uuid": "^10.0.0"
},
"dependencies": {
"node-addon-api": "8.3.1",
"@aws-sdk/client-kms": "^3.637.0",
"@aws-sdk/credential-providers": "^3.637.0",
"@azure/identity": "^4.4.1",
Expand Down
Loading