-
Notifications
You must be signed in to change notification settings - Fork 20
[CLI-3745] Use default max ecku to scale limits when not set in CMK response #3237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the logic for calculating ingress and egress limits for Kafka clusters to use a default max eCKU value when the current max eCKU is not set in the CMK response, rather than returning unscaled limits.
Key changes:
- Modified the scaling logic to use the default max eCKU from the limits response when
currentMaxEckuis zero - Added test coverage for the new default max eCKU scaling behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/kafka/utils.go |
Updated getCmkClusterIngressAndEgressMbps to use default max eCKU for scaling when current max eCKU is not set |
test/test-server/kafka_usage_limits_handler.go |
Added new test case ID for testing default v2 limits behavior |
test/fixtures/output/kafka/cluster/describe-basic-with-default-v2-limits.golden |
Added golden file with expected output showing scaled limits (250 MB/s ingress, 750 MB/s egress) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/fixtures/output/kafka/cluster/describe-basic-with-default-v2-limits.golden
Show resolved
Hide resolved
2b0b80e
|




Release Notes
Breaking Changes
New Features
Bug Fixes
confluent kafka cluster describecommand to use default max ecku value when currentMaxEcku is not setChecklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Blast Radius
No
References
Test & Review
Manual verification results
Limits returned with default max ecku

Confirmed that max ecku is not returned in cmk response for this cluster

But it has default max ecku in DB
