Skip to content

Conversation

@marantunez
Copy link
Member

@marantunez marantunez commented Dec 3, 2025

Release Notes

Breaking Changes

  • PLACEHOLDER

New Features

  • PLACEHOLDER

Bug Fixes

  • Update the display value of Ingress Limit and Egress Limit field for confluent kafka cluster describe command to use default max ecku value when currentMaxEcku is not set

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

  • Follow up from [CLI-3745] Integrate CLI with kafka Usage Limits API #3217 to use the default max ecku from the limits api to scale other limits when the clusters current max ecku is not available in the cmk response
  • This is needed since we are trying to decouple the max ecku release from the usage limits. So the cmk response won't have the max_ecku in the response yet.

Blast Radius

No

References

Test & Review

  • Added integration test
  • Manual verification results in stag
Manual verification results

Limits returned with default max ecku
image

Confirmed that max ecku is not returned in cmk response for this cluster
image

But it has default max ecku in DB
image

@marantunez marantunez requested a review from a team as a code owner December 3, 2025 22:11
Copilot AI review requested due to automatic review settings December 3, 2025 22:11
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the logic for calculating ingress and egress limits for Kafka clusters to use a default max eCKU value when the current max eCKU is not set in the CMK response, rather than returning unscaled limits.

Key changes:

  • Modified the scaling logic to use the default max eCKU from the limits response when currentMaxEcku is zero
  • Added test coverage for the new default max eCKU scaling behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
internal/kafka/utils.go Updated getCmkClusterIngressAndEgressMbps to use default max eCKU for scaling when current max eCKU is not set
test/test-server/kafka_usage_limits_handler.go Added new test case ID for testing default v2 limits behavior
test/fixtures/output/kafka/cluster/describe-basic-with-default-v2-limits.golden Added golden file with expected output showing scaled limits (250 MB/s ingress, 750 MB/s egress)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@marantunez marantunez requested a review from Copilot December 3, 2025 22:23

This comment was marked as duplicate.

This comment was marked as resolved.

cqin-confluent
cqin-confluent previously approved these changes Dec 4, 2025
tmodi11
tmodi11 previously approved these changes Dec 4, 2025
@airlock-confluentinc airlock-confluentinc bot dismissed stale reviews from tmodi11 and cqin-confluent via 2b0b80e December 5, 2025 06:01
@sonarqube-confluent
Copy link

@cqin-confluent cqin-confluent merged commit ac76c8b into main Dec 8, 2025
3 checks passed
@cqin-confluent cqin-confluent deleted the CLI-3745-update-max-ecku branch December 8, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants