Azure support on csmt artifacts commands #3230
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds Azure cloud support to Confluent connect artifact commands (create, list, describe, delete), expanding the existing AWS-only implementation to support both AWS and Azure cloud providers.
Key Changes:
- Updates all artifact commands to accept both AWS and Azure cloud providers via flag changes
- Implements Azure-specific file upload logic using blob storage for artifact creation
- Validates cloud provider input against both AWS and Azure
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/connect/command_artifact_list.go | Updates cloud flag to accept both AWS and Azure |
| internal/connect/command_artifact_describe.go | Updates cloud flag to accept both AWS and Azure |
| internal/connect/command_artifact_delete.go | Updates cloud flag to accept both AWS and Azure |
| internal/connect/command_artifact_create.go | Updates cloud flag, adds Azure upload logic, and validates against both cloud providers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ashrivastava88
changed the title
|
| return err | ||
| } | ||
| } else { | ||
| if err := utils.UploadFile(resp.GetUploadUrl(), artifactFile, resp.GetUploadFormData()); err != nil { |
There was a problem hiding this comment.
lets rename UploadFile to refelect in the name that it is only for aws
There was a problem hiding this comment.
Hi @tmalikconfluent
This is a utils method being used across many other flows, (flink udfs uploads, custom connect plugin uploads),owned by other teams.
Inclined towards not changing it right now,, as it increased the testing effort for all other flows.
|
Overall looks great! I just want to make sure there are no azure specific fields we need to add to the describe and list commands here right? |
@tmalikconfluent |
Release Notes
Breaking Changes
New Features
Bug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Cli support for connect artifact upload for csmt connectors was already enabled for AWS, with this PR we are enabling/supporting it for azure
Blast Radius
Changes affect Upload artifact flow for connect artifacts
References
https://confluentinc.atlassian.net/browse/CC-37890
Test & Review
This PR has been tested by building the binary, and testing against stag environment (stag.cpdev.cloud). Testing has been done for both AWS as well as Azure
List artifact AWS ✅
List artifact Azure ✅
Create artifact AWS ✅
Describe Artifact AWS ✅
Create artifact Azure ✅
Describe Artifact Azure ✅
Delete Artifact AWS ✅
Delete Artifact Azure ✅
