-
Notifications
You must be signed in to change notification settings - Fork 20
[APIE-713] - Add support for CP Flink savepoint management #3226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
sgagniere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few nitpicks:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive support for Flink savepoint management in Confluent Platform by introducing new CLI commands for both regular and detached savepoints. The implementation provides full CRUD operations and integrates with the CMF REST API through an updated SDK.
Key Changes:
- Added
confluent flink savepointcommands (create, list, describe, delete, detach) for managing savepoints associated with applications and statements - Added
confluent flink detached-savepointcommands (create, list, describe, delete) for managing standalone savepoints - Updated CMF SDK from v0.0.4 to v0.0.5 and refactored REST client to use specialized API interfaces
Reviewed changes
Copilot reviewed 81 out of 84 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/flink/command_savepoint*.go | Implements savepoint CRUD operations with support for both application and statement contexts |
| internal/flink/command_detached_savepoint*.go | Implements detached savepoint management commands independent of applications/statements |
| pkg/flink/cmf_rest_client.go | Refactored to use specialized API interfaces and added savepoint-related client methods |
| test/test-server/flink_onprem_*.go | Added mock handlers and routes for savepoint endpoints to support integration testing |
| test/flink_onprem_test.go | Added comprehensive integration tests covering all savepoint operations |
| test/fixtures/output/flink/* | Added golden files for test output validation across different scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sgagniere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I left some comments, but most of them are small / nitpicks.
a6b7f9c to
6c29c39
Compare
sgagniere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Just a few more comments, mostly about test coverage
|




Release Notes
Breaking Changes
New Features
confluent flink savepointandconfluent flink detached-savepointcommandsBug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
CLI for CP Flink savepoint management
Blast Radius
flink application commands could be affected
References
https://confluentinc.atlassian.net/browse/APIE-713
Test & Review
Added extensive integration tests.
Manual testing link: https://docs.google.com/document/d/1IifibpQAUlWNx6zMhSJfL-NMr4VxjbajQxne6vNE8Ao/edit?tab=t.0