Skip to content

Conversation

@tmalikconfluent
Copy link
Contributor

@tmalikconfluent tmalikconfluent commented Nov 17, 2025

Release Notes

Breaking Changes

  • PLACEHOLDER

New Features

  • Add confluent flink savepoint and confluent flink detached-savepoint commands

Bug Fixes

  • PLACEHOLDER

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

CLI for CP Flink savepoint management

Blast Radius

flink application commands could be affected

References

https://confluentinc.atlassian.net/browse/APIE-713

Test & Review

Added extensive integration tests.
Manual testing link: https://docs.google.com/document/d/1IifibpQAUlWNx6zMhSJfL-NMr4VxjbajQxne6vNE8Ao/edit?tab=t.0

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link
Member

@sgagniere sgagniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few nitpicks:

@tmalikconfluent tmalikconfluent changed the title cmf SDK changes needed for refractor [APIE-713] - Add support for CP Flink savepoint management Dec 1, 2025
@tmalikconfluent tmalikconfluent marked this pull request as ready for review December 9, 2025 01:20
@tmalikconfluent tmalikconfluent requested a review from a team as a code owner December 9, 2025 01:20
Copilot AI review requested due to automatic review settings December 9, 2025 01:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive support for Flink savepoint management in Confluent Platform by introducing new CLI commands for both regular and detached savepoints. The implementation provides full CRUD operations and integrates with the CMF REST API through an updated SDK.

Key Changes:

  • Added confluent flink savepoint commands (create, list, describe, delete, detach) for managing savepoints associated with applications and statements
  • Added confluent flink detached-savepoint commands (create, list, describe, delete) for managing standalone savepoints
  • Updated CMF SDK from v0.0.4 to v0.0.5 and refactored REST client to use specialized API interfaces

Reviewed changes

Copilot reviewed 81 out of 84 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
internal/flink/command_savepoint*.go Implements savepoint CRUD operations with support for both application and statement contexts
internal/flink/command_detached_savepoint*.go Implements detached savepoint management commands independent of applications/statements
pkg/flink/cmf_rest_client.go Refactored to use specialized API interfaces and added savepoint-related client methods
test/test-server/flink_onprem_*.go Added mock handlers and routes for savepoint endpoints to support integration testing
test/flink_onprem_test.go Added comprehensive integration tests covering all savepoint operations
test/fixtures/output/flink/* Added golden files for test output validation across different scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@sgagniere sgagniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I left some comments, but most of them are small / nitpicks.

Copy link
Member

@sgagniere sgagniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just a few more comments, mostly about test coverage

@sonarqube-confluent
Copy link

@tmalikconfluent tmalikconfluent merged commit 9ae4710 into main Dec 18, 2025
3 checks passed
@tmalikconfluent tmalikconfluent deleted the update-cmf branch December 18, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants