Skip to content

Conversation

@cqin-confluent
Copy link
Member

Release Notes

Breaking Changes

  • PLACEHOLDER

New Features

  • PLACEHOLDER

Bug Fixes

  • PLACEHOLDER

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

Blast Radius

References

Test & Review

Copilot AI review requested due to automatic review settings November 14, 2025 18:20
@cqin-confluent cqin-confluent requested a review from a team as a code owner November 14, 2025 18:20
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds multi-environment support for AWS ingress private link functionality in the CLI, extending the existing egress private link capabilities. The changes enable users to create, manage, and interact with AWS ingress private link gateways and endpoints.

Key Changes:

  • Added support for AWS ingress private link gateway type alongside existing egress private link
  • Implemented complete CRUD operations for ingress endpoints (create, list, describe, update, delete)
  • Updated dependency versions for networking-access-point and networking-gateway SDKs

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/network/command_gateway.go Added AWS ingress private link gateway type constants and mapping
internal/network/command_gateway_create.go Added ingress-privatelink gateway creation support with AWS-only validation
internal/network/command_gateway_list.go Extended list command to display region and principal ARN for ingress gateways
internal/network/command_access_point_private_link.go Added ingress-endpoint subcommand to private-link command tree
internal/network/command_access_point_private_link_ingress_endpoint.go Core ingress endpoint functionality including output formatting and autocomplete
internal/network/command_access_point_private_link_ingress_endpoint_create.go Implements ingress endpoint creation with AWS VPC endpoint service configuration
internal/network/command_access_point_private_link_ingress_endpoint_list.go Lists ingress endpoints with filtering by display names
internal/network/command_access_point_private_link_ingress_endpoint_describe.go Describes individual ingress endpoint details
internal/network/command_access_point_private_link_ingress_endpoint_update.go Updates ingress endpoint display name
internal/network/command_access_point_private_link_ingress_endpoint_delete.go Deletes one or more ingress endpoints with confirmation
go.mod Updated SDK dependencies to internal versions with ingress support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +50 to +52
if ingressEndpoint.Spec.GetConfig().NetworkingV1AwsIngressPrivateLinkEndpoint == nil {
continue
}
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filtering logic is duplicated from the autocomplete function. Consider extracting a helper function like isIngressEndpoint(accessPoint) to reduce code duplication and improve maintainability.

Copilot uses AI. Check for mistakes.
Comment on lines 28 to 33
Text: "Create an AWS ingress private link gateway.",
Code: "confluent network gateway create --cloud aws --region us-east-1 --type ingress-privatelink",
},
examples.Example{
Text: "Create an AWS private network interface gateway.",
Code: "confluent network gateway create --cloud aws --region us-east-1 --type private-network-interface",
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example command is missing the gateway name argument that appears in the adjacent egress example (line 25). For consistency, either add a name to this example or clarify that the name is optional in the command documentation.

Suggested change
Text: "Create an AWS ingress private link gateway.",
Code: "confluent network gateway create --cloud aws --region us-east-1 --type ingress-privatelink",
},
examples.Example{
Text: "Create an AWS private network interface gateway.",
Code: "confluent network gateway create --cloud aws --region us-east-1 --type private-network-interface",
Text: `Create AWS ingress private link gateway "my-ingress-gateway".`,
Code: "confluent network gateway create my-ingress-gateway --cloud aws --region us-east-1 --type ingress-privatelink",
},
examples.Example{
Text: `Create AWS private network interface gateway "my-pni-gateway".`,
Code: "confluent network gateway create my-pni-gateway --cloud aws --region us-east-1 --type private-network-interface",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants