-
Notifications
You must be signed in to change notification settings - Fork 20
[MATRIX-1216] added basic auth support for mcp connections #3220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds basic authentication (username/password) support for MCP_SERVER connection types in Flink connections, expanding the available authentication methods alongside existing API key, bearer token, and OAuth2 options.
Key Changes:
- Added username/password as valid authentication credentials for mcp_server connection type
- Updated test coverage to include basic auth scenario for mcp_server connections
- Updated help text and documentation to reflect new authentication option
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/flink_test.go | Added test case for mcp_server connection creation with username/password authentication |
| pkg/flink/utils.go | Updated connection type mappings to include username/password as valid secrets for mcp_server |
| test/fixtures/output/flink/connection/*.golden | Updated help text in multiple test fixtures to document username/password support for mcp_server |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aa040a7 to
1273b83
Compare
|
letaoj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We might also need to update the gateway to loose the check on basic auth
Yes gateway changes are already merged |
|
@yanand0909 , can you rebase and ask CLI team to take a look? |
@lihaosky A2A changes were reverted as the gateway changes has not made it to prod yet but cli team is tracking this here |
|
ok. So we are waiting for a2a revert revert and then rebase this |
Yes |





Release Notes
New Features
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Added basic authentication support for MCP_SERVER connection type
Blast Radius
This is a new authentication feature support and independent to the existing ones so should not affect anything
References
https://confluentinc.atlassian.net/browse/MATRIX-1216
Test & Review
Added test for this and tested with locally built binary, snapshots of which is added in below thread
https://confluent.slack.com/archives/CG6BW233L/p1762874095525569