Skip to content

Conversation

@linouk23
Copy link
Contributor

Release Notes

Bug Fixes

  • Updated CLI documentation to remove the outdated note about AWS PrivateLink for the confluent kafka cluster create command.

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • [] I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • [x ] I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

This PR updates CLI documentation to remove the outdated note about AWS PrivateLink for the confluent kafka cluster create command.

Blast Radius

NA, this PR only updates the description of the attribute, which in turn updates the CLI documentation.

References

Test & Review

Copilot AI review requested due to automatic review settings August 21, 2025 02:31
@linouk23 linouk23 requested a review from a team as a code owner August 21, 2025 02:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes outdated documentation that incorrectly stated AWS PrivateLink clusters could not be created via the CLI command. The change simplifies the help text for the confluent kafka cluster create command by removing the restriction note.

  • Removes the outdated AWS PrivateLink restriction from CLI help documentation
  • Updates the command's long description to be more concise
  • Aligns CLI documentation with current functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
internal/kafka/command_cluster_create.go Removes AWS PrivateLink restriction note from the command's long description
test/fixtures/output/kafka/cluster/create-help.golden Updates the expected test output to reflect the simplified help text

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@sonarqube-confluent

This comment has been minimized.

Copy link
Member

@sgagniere sgagniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One small nitpick:

@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (0.00% Estimated after merge)
  • Duplications No duplication information (0.00% Estimated after merge)

Project ID: cli

View in SonarQube

@linouk23 linouk23 requested review from a team and sgagniere August 21, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants