Skip to content

Conversation

@cqin-confluent
Copy link
Member

@cqin-confluent cqin-confluent commented Aug 14, 2025

Release Notes

Breaking Changes

  • PLACEHOLDER

New Features

  • Add a new field of max-ecku to the Kafka Cluster resource, where with each cluster type (Basic, Standard, Enterprise, Freight) users can optionally override the default Confluent-set max eCKU limit with a custom value

Bug Fixes

  • PLACEHOLDER

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

This feature allows users to set a custom max-ecku value for their v2 clusters (Basic, Standard, Enterprise, and Freight). By doing so, Confluent customers gain more control over cluster scaling.

Context:
Currently, the number of eCKUs that the customer is billed for dynamically changes. Our existing customers are limited by their cluster scaling up to a max eCKU (default limit) value set by Confluent. This feature offers customers autonomy to explicitly define their scale for clusters of types Basic, Standard, Enterprise, and Freight, similar to what’s already supported for Dedicated clusters.

Blast Radius

Confluent Cloud customers who are using confluent kafka cluster subcommands will be impacted.

References

JIRA CLI-3394
Feature Request 1-pager

Test & Review

Manual verification:
CLI Testing and Verification

Integration tests:

❯ make integration-test INTEGRATION_TEST_ARGS="-run TestCLI/TestHelp"
...
PASS
ok      github.com/confluentinc/cli/v4/test     128.246s
?       github.com/confluentinc/cli/v4/test/test-server [no test files]
❯ make integration-test INTEGRATION_TEST_ARGS="-run TestCLI/TestKafka"
...
PASS
ok      github.com/confluentinc/cli/v4/test     67.070s
?       github.com/confluentinc/cli/v4/test/test-server [no test files]

Copilot AI review requested due to automatic review settings August 14, 2025 04:56
@cqin-confluent cqin-confluent requested a review from a team as a code owner August 14, 2025 04:56
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces configurable Max-eCKU (Elastic Confluent Kafka Units) support for Kafka clusters in the CLI. It allows users to specify and update the maximum number of eCKUs that clusters should auto-scale to for Basic, Standard, Enterprise, and Freight cluster types.

Key changes include:

  • Added --max-ecku flag to cluster create and update commands
  • Implemented Max eCKU validation and configuration logic
  • Added comprehensive test coverage for the new functionality

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
internal/kafka/command_cluster_create.go Adds --max-ecku flag and validation logic for cluster creation
internal/kafka/command_cluster_update.go Adds --max-ecku flag and validation logic for cluster updates
internal/kafka/command_cluster_describe.go Adds Max eCKU field to cluster description output
internal/kafka/utils.go Adds getCmkMaxEcku utility function to retrieve Max eCKU values
test/test-server/cmk_handlers.go Updates test server handlers to support Max eCKU configuration
test/kafka_test.go Adds comprehensive test cases for Max eCKU functionality
test/fixtures/output/ Various golden files for test output validation
cmd/lint/main.go Adds "ecku" to vocabulary words list

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

Copy link
Member

@sgagniere sgagniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, here's some comments:

@sonarqube-confluent
Copy link

Failed

  • 71.00% Coverage on New Code (is less than 80.00%)

Analysis Details

5 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 5 Code Smells

Coverage and Duplications

  • Coverage 71.00% Coverage (78.20% Estimated after merge)
  • Duplications No duplication information (0.00% Estimated after merge)

Project ID: cli

View in SonarQube

Copy link
Member

@sgagniere sgagniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one more small comment:

@sonarqube-confluent
Copy link

Copy link
Member

@sgagniere sgagniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants