-
Notifications
You must be signed in to change notification settings - Fork 20
[CLI-3394] Configurable Max-eCKU #3151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces configurable Max-eCKU (Elastic Confluent Kafka Units) support for Kafka clusters in the CLI. It allows users to specify and update the maximum number of eCKUs that clusters should auto-scale to for Basic, Standard, Enterprise, and Freight cluster types.
Key changes include:
- Added
--max-eckuflag to cluster create and update commands - Implemented Max eCKU validation and configuration logic
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/kafka/command_cluster_create.go | Adds --max-ecku flag and validation logic for cluster creation |
| internal/kafka/command_cluster_update.go | Adds --max-ecku flag and validation logic for cluster updates |
| internal/kafka/command_cluster_describe.go | Adds Max eCKU field to cluster description output |
| internal/kafka/utils.go | Adds getCmkMaxEcku utility function to retrieve Max eCKU values |
| test/test-server/cmk_handlers.go | Updates test server handlers to support Max eCKU configuration |
| test/kafka_test.go | Adds comprehensive test cases for Max eCKU functionality |
| test/fixtures/output/ | Various golden files for test output validation |
| cmd/lint/main.go | Adds "ecku" to vocabulary words list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sgagniere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, here's some comments:
sgagniere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just one more small comment:
|
sgagniere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm




Release Notes
Breaking Changes
New Features
Bug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
This feature allows users to set a custom max-ecku value for their v2 clusters (Basic, Standard, Enterprise, and Freight). By doing so, Confluent customers gain more control over cluster scaling.
Context:
Currently, the number of eCKUs that the customer is billed for dynamically changes. Our existing customers are limited by their cluster scaling up to a max eCKU (default limit) value set by Confluent. This feature offers customers autonomy to explicitly define their scale for clusters of types Basic, Standard, Enterprise, and Freight, similar to what’s already supported for Dedicated clusters.
Blast Radius
Confluent Cloud customers who are using confluent kafka cluster subcommands will be impacted.
References
JIRA CLI-3394
Feature Request 1-pager
Test & Review
Manual verification:
CLI Testing and Verification
Integration tests: