-
Notifications
You must be signed in to change notification settings - Fork 20
INC-3834 Fix #3142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
INC-3834 Fix #3142
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes early validation of topic existence/permissions in favor of allowing Kafka to handle authorization checks directly. The change updates the topic validation logic to proceed with operations even when topics are not visible in metadata, which could be due to ACL restrictions.
- Removes error messages and suggestions related to topic validation failures
- Updates
ValidateTopicfunctions to log and continue instead of returning errors - Shifts authorization handling from CLI pre-validation to Kafka server-side validation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/errors/error_message.go | Removes topic validation error message constants |
| internal/kafka/command_topic_onprem.go | Updates on-premises topic validation to proceed instead of failing |
| internal/kafka/command_topic.go | Updates cloud topic validation to proceed instead of failing |
internal/kafka/command_topic.go
Outdated
| fmt.Sprintf(errors.TopicDoesNotExistOrMissingPermissionsSuggestions, cluster.ID), | ||
| ) | ||
| log.CliLogger.Tracef("validateTopic: Topic '%s' not visible in metadata, this could be due to ACL restrictions. Proceeding with operation to allow Kafka to handle authorization.", topic) | ||
| return nil |
Copilot
AI
Jul 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is inconsistent with the surrounding code. The return statement has extra tabs that don't align with the rest of the function.
| return nil | |
| return nil |
Release Notes
Breaking Changes
New Features
Bug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Blast Radius
References
Test & Review