attester: tdx: strip CCEL #575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had forgotten this. It's tested and ready now: |
Xynnn007
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Thanks for the patch and this would make great sense to efficiency. This is the producer side code. I wonder if any unit tests with ccels that produced by this patch could be added to the verifier side?
|
It's possible to update |
The CCEL log is made available through an ACPI sysfs entry and is of size "log_area_minimum_length". OVMF sets it to 64k. The current tdx-attester code reads the whole blob and it's used as is in encoding and when sent over the wire. Test runs suggests that it could be beneficial to strip the log before processing it further: Squeezed from 65536 to 5064 bytes The stripping follows the same pattern as what eventlog-rs does on the receiving end (we keep the same "stop flag" in the blob to keep things compatible). Signed-off-by: Mikko Ylinen <[email protected]>
mythi
force-pushed
the
tdx-attester-1
branch
from
b27905c to
3c89f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #569
The CCEL log is made available through an ACPI sysfs entry and is of size "log_area_minimum_length". OVMF sets it to 64k.
The current tdx-attester code reads the whole blob and it's used as is in encoding and when sent over the wire.
Test runs suggests that it could be beneficial to strip the log before processing it further:
Squeezed from 65536 to 5064 bytes
The stripping follows the same pattern as what eventlog-rs does on the receiving end (we keep the same "stop flag" in the blob to keep things compatible).