[WIP]: enhance security with safe-path #23
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OCI image spec has a section named `Conversion to OCI Runtime Configuration`, which defines how to generate a default runtime configuration from an image. So add more comments to create_runtime_config() by quoting spec definitions. Signed-off-by: Jiang Liu <[email protected]>
Obey the precedence rule defined the OCI image spec when generating annotations for runtime configuration. Signed-off-by: Jiang Liu <[email protected]>
There are three more annotations defined by the OCI image spec, so add support for them. Signed-off-by: Jiang Liu <[email protected]>
Use the safe-path crate to protect from possible path related attacks. Signed-off-by: Jiang Liu <[email protected]>
jodh-intel
reviewed
Apr 27, 2022
| let bundle_config = bundle_path.join(BUNDLE_CONFIG); | ||
| spec.save(&bundle_config)?; | ||
|
|
||
| Ok(bundle_config) | ||
| PinnedPathBuf::new(bundle_path, BUNDLE_CONFIG) | ||
| .context("The path of generated config.json file has changed, possible attack!") |
There was a problem hiding this comment.
- Could you use
BUNDLE_CONFIGrather than hard-codingconfig.json. - I wonder if we want to use a standard "eye catcher" / tag for scenarios like this (maybe use a "SECURITY" prefix in the context message?) That would make errors like this more
grep(1)-able.
|
Ping @jiangliu. |
|
Re-ping @jiangliu 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.