Docker provider e2e test #2188
Draft
Docker provider e2e test #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a callable workflow that run the e2e tests for the docker provider. This workflow is similar to e2e_libvirt.yaml. Signed-off-by: Wainer dos Santos Moschetta <[email protected]> Signed-off-by: stevenhorsman <[email protected]>
This will make the e2e tests for docker to run. Initially it's disabled on pull requests, so only running with the nightly and manual triggers. Notice that's set continue-on-error so that the e2e_run_all workflow exit status won't change, i.e. any failure on e2e_docker is disregarded. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
|
Thanks @stevenhorsman ! I ran on my fork but it failed to install caa: https://github.com/wainersm/cc-cloud-api-adaptor/actions/runs/12180636082/job/33975999946 I will add a step to gather logs at the end of the job on fail, as we do for libvirt. |
Created the ./hack/ci-e2e-debug-fail.sh script out of the debug step of e2e_libvirt. Added such as step to e2e_docker and calls the new script. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
Use the common debug script: ./hack/ci-e2e-debug-fail.sh Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
|
@stevenhorsman pushed two new commits to enable debug on docker workflow. On https://github.com/wainersm/cc-cloud-api-adaptor/actions/runs/12185682757/job/33993001651, it fail to start caa: The caa image being used has no support for docker... is the support built in by default? |
|
So we need to use the dev image to get libvirt support due to libvirt using cgo bindings. |
|
I think there is also an issue with |
As discussed in confidential-containers#2171 the CAA_IMAGE envs are not working in the e2e code and combined with the installation directory, it seems seems to add confusion when we need different CAA images for decoupling of different architectures, so switch docker to use the same approach as libvirt for consistency.
|
@wainersm I've made and pushed the change that should fix the CAA issue and testing it now. I think it can be fixup'd into a previous commit, but as it might be controversial I wanted to give you the chance to see it first |
|
Hi @stevenhorsman !
I accepted the pre_install stuff makes no sense anymore. Yep, let's remove it completely when we finish the removal of packer workflows. Ah, I think we should leave your last commit as is, the commit message has a nice explanation for the history of this git repository. Did the test finish? Worked out? |
The test failed: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/12196066119/job/34023415633 We only seem to get the last ~10 lines of the CAA log which isn't super helpful in this case. I think it might have to be a manual debug, though I tried that a few weeks ago when I first wrote some of this code and didn't get very far. I'm not sure if we still get this problem: https://github.com/confidential-containers/cloud-api-adaptor/tree/main/src/cloud-api-adaptor/docker#troubleshooting that used to always happy on the docker provider? |
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
Yeah, I will reserve some time to debug locally. In any case I sent an fixup to print all caa log messages. For the records, I never made the docker provider to work locally (nor on my tentative to introduce the CI workflow) :( |
Yeah, I haven't had it working for a long time. I think Pradipta might have though. |
|
I was able to reproduce it locally. Looking at a dangling podvm container, the The only files mounted in |
The daemon.json is created by process_user_data - https://github.com/confidential-containers/cloud-api-adaptor/blob/main/src/cloud-providers/docker/provider.go#L78 |
|
This may be related if you were using latest code - #2222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on Wainer's PR #1965, with some work done to make it fit into the new e2e world