Improve error message #10
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Can you add tests for your changes? |
|
I now barely understand why I did the things as I did them... I need definitely re-think this and add tests to get this code nice and tidy. |
thet
force-pushed
the
improve-error-message
branch
3 times, most recently
from
3355235 to
832c727
Compare
thet
force-pushed
the
improve-error-message
branch
from
832c727 to
7ec5ad3
Compare
This allows to run some code in an error case, e.g. to add a user-visible status message.
thet
force-pushed
the
improve-error-message
branch
from
7ec5ad3 to
9cb6ecd
Compare
|
I updated the code, made it more clear and added tests. Ready to review... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE @rnixx @lenadax
I changed the PR in CMFPlone to not belong anymore on this PR.
The callback isn't necessary anymore!
In this case, I'd even remove the callback commit.
However, at least the change which handles resolver errors gracefully is useful[
What do you think?
Belongs together:
- Dont break resource registry plone/Products.CMFPlone#4165-> the CMFPlone PR doesn't depend anymore on this.Dependency problem with resources without these fixes or by just using
webresource.GracefulResourceRenderer:Dependency problem with the two PRs in place:
Note: The circular dependency problem seems to be incorrect.