Skip to content
This repository has been archived by the owner on May 9, 2023. It is now read-only.

Commit

Permalink
Rename AdminClient.fromManagedJavaClient to `AdminClient.fromScoped…
Browse files Browse the repository at this point in the history
…JavaClient` to follow ZIO2 conventions && Remove "Managed" from documentation (#117)
  • Loading branch information
guizmaii committed Jan 8, 2023
1 parent db3c046 commit 199a08a
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions zio-kafka/src/main/scala/zio/kafka/admin/AdminClient.scala
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import org.apache.kafka.common.{
Uuid
}
import zio._

import zio.kafka.admin.acl._

import java.util.Optional
Expand Down Expand Up @@ -1405,15 +1404,15 @@ object AdminClient {
}

def make(settings: AdminClientSettings): ZIO[Scope, Throwable, AdminClient] =
fromManagedJavaClient(javaClientFromSettings(settings))
fromScopedJavaClient(javaClientFromSettings(settings))

def fromJavaClient(javaClient: JAdmin): URIO[Any, AdminClient] =
ZIO.succeed(new LiveAdminClient(javaClient))

def fromManagedJavaClient[R, E](
managedJavaClient: ZIO[R with Scope, E, JAdmin]
def fromScopedJavaClient[R, E](
scopedJavaClient: ZIO[R with Scope, E, JAdmin]
): ZIO[R with Scope, E, AdminClient] =
managedJavaClient.flatMap { javaClient =>
scopedJavaClient.flatMap { javaClient =>
fromJavaClient(javaClient)
}

Expand Down

0 comments on commit 199a08a

Please sign in to comment.