Migrate last set of test examples to use the new parametrization decorator#1284
Merged
Conversation
conda-bot
added
the
cla-signed
marcoesters
reviewed
Jul 9, 2026
| @pytest.mark.skipif(sys.platform != "darwin", reason="macOS only") | ||
| def test_example_osxpkg(tmp_path, request): | ||
| @pytest.mark.parametrize("installer_type", installer_types_for_example(_example_path("osxpkg"))) | ||
| def test_example_osxpkg(tmp_path, request, installer_type): |
Contributor
There was a problem hiding this comment.
Do we need to parametrize the PKG tests? They are only intended for one installer type, so this seems unnecessary.
marcoesters
previously approved these changes
Jul 9, 2026
marcoesters
left a comment
marcoesters
left a comment
Contributor
There was a problem hiding this comment.
One non-blocking suggestion, but LGTM
| ) | ||
| def test_example_osxpkg_extra_pages(tmp_path, installer_type): | ||
| def test_example_osxpkg_extra_pages(tmp_path): | ||
| installer_type = "pkg" |
Contributor
There was a problem hiding this comment.
That's one option, or create_single_installer takes None and then just takes whatever is in the construct.yaml file.
marcoesters
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the last PR covering the improvements done to the test examples (based on the work from #1278).
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?