-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better document run_test.r #5479
Conversation
CodSpeed Performance ReportMerging #5479 will not alter performanceComparing Summary
|
@beeankha is there any interest in reviewing this documentation-only PR? I see that you keep merging in main, but this PR doesn't touch the code, so it's not going to make a difference in the CI checks. |
Hi @jdblischak thank you for your patience! I'm actively getting some opinions on this addition to see if it's OK to merge; aiming to get it approved and merged before the end of this week, pending CI tests passing (not sure yet what the test failures are indicating, but I will be looking into those in the next few days as well). |
Thanks so much for helping to improve our documentation! I'll approve once the tests run green. |
@beeankha I know this is just a doc update and it shouldn't affect the CI tests (and also you approved it). Is that failing test a known issue? |
The previously-failing tests were a known issue that have been resolved, and now we're just dealing with some CI infrastructure hiccups (i.e. network errors vs test failures). The latest re-run should hopefully come back all green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty!
Description
This is a documentation-only PR to better advertise the existence of
run_test.r
. Most of the documentation only refers to.bat
,.sh
, and.py
, with the occasional reference to.pl
. Looking through the entire conda-forge org, I found zero instances ofrun_test.r
; whereas, I found 329 instances of the better documentedrun_test.py
.I had to do a lot of digging to convince myself that it should work:
run_test.r
fix run_test.r test files with R #1869.r
(R scripts are conventionally.R
)conda-build/conda_build/build.py
Line 3143 in 12fc37c
pl_files
andlua_files
were defined, so this might not be trueconda-build/conda_build/post.py
Line 761 in 12fc37c
At minimum I know
run_test.r
will work with R recipes, since I just recently added it to r-git2r-feedstock in conda-forge/r-git2r-feedstock@f9d4ff1Checklist - did you ...
news
directory (using the template) for the next release's release notes?