Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for defining _CONDA_BUILD_ISOLATED_ACTIVATION in meta.yaml #4816

Closed

Conversation

kenodegard
Copy link
Contributor

Description

The _CONDA_BUILD_ISOLATED_ACTIVATION environment variable is special and can currently only be set prior to running conda build, (e.g. _CONDA_BUILD_ISOLATED_ACTIVATION=1 conda build ...). This makes it hard to enable for packaging teams that do not normally expose this kinds of customizations. So instead of exclusively relying on a pre-set environment variable, let's also allow the value to be set within meta.yml's build/script_env.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard self-assigned this Mar 21, 2023
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 21, 2023
@dholth
Copy link
Contributor

dholth commented Mar 23, 2023

Why is the environment variable underscore-prefixed _CONDA_BUILD_ISOLATED_ACTIVATION?

@kenodegard
Copy link
Contributor Author

To indicate that its private?

@jezdez
Copy link
Member

jezdez commented Mar 24, 2023

I'm not sure this should be "private" if it becomes part of the recipe format. Are there other ways to add this as a first-level recipe option?

@kenodegard
Copy link
Contributor Author

@jezdez I don't want this environment variable to become an official meta.yaml setting. IMO isolated mode should be the only mode conda is ever invoked as. We also need to work to eliminate the need to run conda via subprocess in the first place. Furthermore, there needs to be proper API end-points that conda-build should call instead.

@kenodegard
Copy link
Contributor Author

we are collectively displeased with this solution and should consider something like conda-forge/conda-feedstock#204 instead

@kenodegard kenodegard closed this Jun 15, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jun 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants