ADD LabJackPython 4-24-2014 #2213
Conversation
This has a non-PEP440 compliant version number so it may fail, but let’s try it.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/labjackpython:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but couldn't find any. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| build: | ||
| - python | ||
| run: | ||
| - python |
There was a problem hiding this comment.
Indented to 4 spaces, but everything else is 2. Could we please pick an indent level and stick with it?
| home: http://labjack.com/support/labjackpython | ||
| summary: "Python module for communicating with the LabJack U3/U6/UE9/U12." | ||
| license: MIT X-11 | ||
| license_family: MIT |
There was a problem hiding this comment.
The License is included at the end of the Readme. Just the README file as the license_file? Copy the license into a new file in the conda recipe folder?
There was a problem hiding this comment.
Please raise an issue upstream and ask for a proper license file. This makes it easier for people to determine how the code is licensed. Also please ask that it gets included in the MANIFEST.in. This will help with packaging the license file when the project starts making PyPI releases.
| {% set name = "LabJackPython" %} | ||
| {% set org = "labjack" %} | ||
| {% set upstreamversion = "4-24-2014" %} | ||
| {% set version = "20140424" %} |
There was a problem hiding this comment.
Would be good if we could determine one of these programmatically from the other. That way there is less chance of a having a mismatch in a release.
There was a problem hiding this comment.
Agreed - that would be useful. I looked at strftime formatting in jinja but didn't see any obvious way to do this, and versions are fairly infrequent, so don't think doing it separately here is the worst thing in the world. Can you think of a better way to get dates into jinja?
There was a problem hiding this comment.
I'm probably too lazy to be that clever. Would just do something like "."join(upstreamversion.split("-")[::-1]) in Python. Probably needs some tweaks for Jinja. Having . are very important as it makes this PEP 440 compatible. Also it may make pinning and version comparison easier later as conda supports this..
There was a problem hiding this comment.
xref: labjack/LabJackPython#93
| about: | ||
| home: http://labjack.com/support/labjackpython | ||
| summary: "Python module for communicating with the LabJack U3/U6/UE9/U12." | ||
| license: MIT X-11 |
There was a problem hiding this comment.
Normally we just say MIT. Though this is up to you.
There was a problem hiding this comment.
Thanks - I cleaned up the version with . to be PEP440 compatible, but I couldn't find a clean way to run straight python in jinja without doing some weird macroing/filtering stuff (although to be fair I didn't look that hard).
Do you know how to run vanilla python directly? Think that just hardcoding will be sufficient, until the upstream version gets fixed (a la the xref)?
|
Remaining issues can be fixed in the feedstock |
This has a non-PEP440 compliant version number so it may fail, but let’s try it.