Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unishox2-py3 recipe #20798

Closed
wants to merge 10 commits into from
Closed

add unishox2-py3 recipe #20798

wants to merge 10 commits into from

Conversation

oschwengers
Copy link

@oschwengers oschwengers commented Oct 19, 2022

This PR adds Unishox2-py3 as a Python binding to the original Unishox2 string compression C library.

The original and main developer @tweedge is informed (tweedge/unishox2-py3#7) and agreed to be mentioned as a package maintainer.

Since I'm not a Python/C hybrid expert and not involved in the development of either Unishox2 or unishox2-py3, all statements below are made to the best of my knowledge. Certainly, @tweedge can provide much better answers to all questions related to the static Unishox2 library which is part of this Python binding library.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/unishox2-py3) and found it was in an excellent condition.

@oschwengers
Copy link
Author

@conda-forge/staged-recipes This grayskull-generated and amended recipe is ready for review. Builds for Win and arm64 are skipped, since we could not get them to work.

Copy link
Member

@carterbox carterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we could not get them to work

What were the error messages?

Comment on lines +41 to +42
license_file:
- LICENSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library is revendoring unishox2 which is not allowed. Typically, we would ask you to devendor unishox2 into its own package and dynamically link, but since unishox2 is so small we will treat it as a header-only library.

In this case, as explicitly mentioned in the checklist, you must include the license of the statically-linked/revendored library. The license of unishox2 and unishox2-py3 are different because the license holders are not the same, so please include both.

recipes/unishox2-py3/meta.yaml Outdated Show resolved Hide resolved
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/unishox2-py3-{{ version }}.tar.gz
sha256: cd2595de196ffd8b93bea7a76f5796d8293f32d1f7c9d3660af0b764ab917963

build:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
build:
build:
ignore_run_exports_from:
- {{ compiler('cxx') }}

Because the standard library isn't used.

Co-authored-by: Daniel Ching <[email protected]>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/unishox2-py3) and found it was in an excellent condition.

@stale
Copy link

stale bot commented Jul 11, 2023

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Jul 11, 2023
Copy link

stale bot commented Jan 1, 2024

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python-c staged-recipes stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

None yet

4 participants