-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unishox2-py3 recipe #20798
add unishox2-py3 recipe #20798
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/staged-recipes This grayskull-generated and amended recipe is ready for review. Builds for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we could not get them to work
What were the error messages?
license_file: | ||
- LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This library is revendoring unishox2 which is not allowed. Typically, we would ask you to devendor unishox2 into its own package and dynamically link, but since unishox2 is so small we will treat it as a header-only library.
In this case, as explicitly mentioned in the checklist, you must include the license of the statically-linked/revendored library. The license of unishox2 and unishox2-py3 are different because the license holders are not the same, so please include both.
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/unishox2-py3-{{ version }}.tar.gz | ||
sha256: cd2595de196ffd8b93bea7a76f5796d8293f32d1f7c9d3660af0b764ab917963 | ||
|
||
build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build: | |
build: | |
ignore_run_exports_from: | |
- {{ compiler('cxx') }} |
Because the standard library isn't used.
Co-authored-by: Daniel Ching <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is Cheers and have a great day! |
This PR adds Unishox2-py3 as a Python binding to the original Unishox2 string compression C library.
The original and main developer @tweedge is informed (tweedge/unishox2-py3#7) and agreed to be mentioned as a package maintainer.
Since I'm not a Python/C hybrid expert and not involved in the development of either Unishox2 or unishox2-py3, all statements below are made to the best of my knowledge. Certainly, @tweedge can provide much better answers to all questions related to the static Unishox2 library which is part of this Python binding library.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).