Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No more cdts6 qt6 and Do not pass -DQT_REQUIRE_HOST_PATH_CHECK=OFF + libbbost 1.86 #287

Merged
merged 8 commits into from
Sep 23, 2024
Merged

No more cdts6 qt6 and Do not pass -DQT_REQUIRE_HOST_PATH_CHECK=OFF + libbbost 1.86 #287

merged 8 commits into from
Sep 23, 2024

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Aug 24, 2024 •
edited
Loading

Closes #291
Closes #286
Closes #279

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

hmaarrfk
hmaarrfk commented Aug 25, 2024
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@hmaarrfk
Copy link
Contributor Author

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor Author

Not sure why aarch is failing with some sha mismatch.... twice....

But linux64's "configuration" as stated by Qt seems to be at parity with the main branch. The one difference seems to be:

  • Main: EGLFS EGLDevice ..... no
  • this branch: EGLFS EGLDevice .... yes

in

2024-08-25T01:26:20.7221148Z QPA backends:
2024-08-25T01:26:20.7221390Z   DirectFB ............................... no
2024-08-25T01:26:20.7221680Z   EGLFS .................................. yes
2024-08-25T01:26:20.7221921Z   EGLFS details:
2024-08-25T01:26:20.7222184Z     EGLFS OpenWFD ........................ no
2024-08-25T01:26:20.7222448Z     EGLFS i.Mx6 .......................... no
2024-08-25T01:26:20.7222737Z     EGLFS i.Mx6 Wayland .................. no
2024-08-25T01:26:20.7223019Z     EGLFS RCAR ........................... no
2024-08-25T01:26:20.7223295Z     EGLFS EGLDevice ...................... yes

@hmaarrfk hmaarrfk mentioned this pull request Aug 25, 2024
Merged
10 tasks
@hmaarrfk hmaarrfk mentioned this pull request Sep 4, 2024
Open
@hmaarrfk
Copy link
Contributor Author

@conda-forge-admin please rerender

hmaarrfk
hmaarrfk commented Sep 16, 2024
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@hmaarrfk hmaarrfk mentioned this pull request Sep 16, 2024
Closed
@hmaarrfk hmaarrfk changed the title No more cdts6 qt6 No more cdts6 qt6 and Do not pass -DQT_REQUIRE_HOST_PATH_CHECK=OFF Sep 16, 2024
@jschueller
Copy link
Contributor

do you think this would work with a new version eg 6.8 ?

@hmaarrfk
Copy link
Contributor Author

we would have to "build it twice" the first time, only the native architectures would build, then we wait 2 hours, then restart the failed builds.

and if we are lucky, it works an additional PR.

@hmaarrfk
Copy link
Contributor Author

@conda-forge-admin please rerender

@hmaarrfk hmaarrfk changed the title No more cdts6 qt6 and Do not pass -DQT_REQUIRE_HOST_PATH_CHECK=OFF No more cdts6 qt6 and Do not pass -DQT_REQUIRE_HOST_PATH_CHECK=OFF + libbbost 1.86 Sep 18, 2024
@hmaarrfk hmaarrfk marked this pull request as ready for review September 19, 2024 01:43
@hmaarrfk
Copy link
Contributor Author

I think something in the double build is corrupting the arm environment sadly....

@hmaarrfk
Copy link
Contributor Author

@conda-forge-admin please rerender

jschueller
jschueller approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@jschueller jschueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go on then

@hmaarrfk
Copy link
Contributor Author

Thanks @jschueller

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Sep 22, 2024
@hmaarrfk
Copy link
Contributor Author

Needs: qt/qttools@687fc16

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Sep 22, 2024
@github-actions GitHub Actions
Copy link

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Sep 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Sep 23, 2024
@github-actions GitHub Actions
Copy link

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Sep 23, 2024
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Sep 23, 2024
@github-actions GitHub Actions
Copy link

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Sep 23, 2024
@github-actions github-actions bot merged commit 2b96d4f into conda-forge:qt6 Sep 23, 2024
7 checks passed
@traversaro traversaro mentioned this pull request Sep 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschueller jschueller jschueller approved these changes

@Tobias-Fischer Tobias-Fischer Awaiting requested review from Tobias-Fischer Tobias-Fischer is a code owner

@andfoy andfoy Awaiting requested review from andfoy andfoy is a code owner

@ccordoba12 ccordoba12 Awaiting requested review from ccordoba12 ccordoba12 is a code owner

@gillins gillins Awaiting requested review from gillins gillins is a code owner

@matthiasdiener matthiasdiener Awaiting requested review from matthiasdiener matthiasdiener is a code owner

@mingwandroid mingwandroid Awaiting requested review from mingwandroid mingwandroid is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@stuarteberg stuarteberg Awaiting requested review from stuarteberg stuarteberg is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmaarrfk @jschueller