Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass -DQT_REQUIRE_HOST_PATH_CHECK=OFF in cross-compiled builds #279

Open
wants to merge 2 commits into
base: qt6
Choose a base branch
from

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jul 8, 2024

As explained in #273 (comment), the PR #274 did not actually solved #273 .

While having a proper fix would be convenient, I am not sure how to do that, so in the short term the best action is to cleanup the recipe, and continue to track the problem in #273 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro
Copy link
Contributor Author

I did not bumped the build number as this is a cleanup meant to be included in the next actual build.

@hmaarrfk
Copy link
Contributor

hmm, these "include in the next build" have been very hard to sync up.

@traversaro
Copy link
Contributor Author

hmm, these "include in the next build" have been very hard to sync up.

If prefer I can bump the build number, feel free to let me know what do you prefer.

@hmaarrfk
Copy link
Contributor

yeah, just bump the build number and merge from the qt6 branch before you do. that way this fix gets in.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro traversaro changed the title [ci skip] ***NO_CI*** Revert "Pass -DQT_REQUIRE_HOST_PATH_CHECK=OFF in cross-compiled builds" Do not pass -DQT_REQUIRE_HOST_PATH_CHECK=OFF in cross-compiled builds Aug 10, 2024
@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

yeah, just bump the build number and merge from the qt6 branch before you do. that way this fix gets in.

Done!

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Aug 10, 2024
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Aug 10, 2024
Copy link

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@hmaarrfk
Copy link
Contributor

does this PR resolve #273?

@traversaro
Copy link
Contributor Author

does this PR resolve #273?

No, it cleans up a previous attempt to fix the issue, that did not do what was intended to do.

@traversaro
Copy link
Contributor Author

The aarch64 build failed for a network issue, I would like to restart just that job but I can't as only maintainer can do that I guess.

@jschueller
Copy link
Contributor

restarted

@jschueller jschueller added the automerge Merge the PR when CI passes label Aug 23, 2024
Copy link

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants