-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt5.15.13 #236
base: main
Are you sure you want to change the base?
Qt5.15.13 #236
Conversation
Update sha256sum
…nda-forge-pinning 2024.03.05.14.24.26
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
continuation of #219 |
download of source code gets stalled :( |
travis ci cancels out during source download, what can I do about it? |
Hey sorry for not responding. I thought a bot had opened this due to an auto-upgrade path. Truthfully, I am not sure this is desirable from an conda-forge ecosystem perspective. The reason is that qtwebengine today cannot be built out easily for mac and windows. if you derisk qt5webengine, then we can start this upgrade. The last migrations of qt5webengine have avoided dependencies on mac and windows, so they have been able to move forward, but having this package would create the following confusion for the solver:
We might be able to use the large machines donated by quantsight. |
I am interested in having qt5webengine updated too. Qt has just released 5.15.13 though so we should aim for that I think. What can I do to help with that? |
Yes. I would aim for lates version today. We can download the manual artifacts from azure here. And upload to our own private channels while we derisk the build system. The general problem with our CIs is that an error will occur at hour 16/17 and we simply can’t detect it unless we get a successful build. |
Sorry I don't quite get what you mean here. Could you be a little more specific about what's the process here? I have available an x86_64 Linux/windows machine and arm64 macOS machine where I can try to build locally, I can use docker on the mac to build linux_aarch64 too I think. I don't have native ppc64 but maybe it can be emulated or cross compiled? |
The parameter you want to specify is Then you can:
It will take a while to get step 5 to work, but with your perseverance, others will come in and help! |
For emulation, you need to install It takes approximately 6x longer to emulate. So not recommended until the very end. |
@conda-forge-admin, please rerender |
it doesn't look like that's possible for travis though, guess I'll need to build qt-main aarch64 locally? |
…nda-forge-pinning 2024.03.12.00.50.18
Yeah, but i have hope for this one. I can build it too and upload it. oddly, x86 targets older Centos by default, so you will have more challenges there. |
Out of curiosity, what is stopping you from moving to qt6 today? |
My goal in the end is to build and ship freecad/ondsel-es to users and it doesn't seem to be ready for qt6 yet. I compiled on linux with qt6 and the experience was still very buggy. Hopefully this will get fixed before end of year but for now I think it's safer to remain in qt5. vtk has also not migrated yet to qt6 and of course I also need webengine too although we plan on eventually dropping this dependency as it's very problematic. |
so where do I download the artifacts? |
thanks, uploaded to https://anaconda.org/freecad/qt-main/files will begin trying qtwebengine maybe tomorrow. I built qt-main linux_aarch64 locally on my mac |
I get this error when trying to build locally:
what could be going wrong? |
are you using the you need to add your channel as a source and rerender. If you open a PR on qt-webengine i can also review there as well. |
@@ -117,7 +117,7 @@ requirements: | |||
- nspr # [unix] | |||
- nss # [unix] | |||
- libsqlite | |||
- mysql-devel # [not win] | |||
- mysql-devel ==8.0 # [not win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this pinned? can we unpin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems maybe there wasn't a global migrator.
this definitely needs one it seems:
Trying to add one here
conda-forge/conda-forge-pinning-feedstock#5637
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, not fun:
qt/qtbase@7d99fa8#diff-1d355c25c0b0eddec2be48253407780c4dc510d986739aec61e1ec892ccaf86e
seems like they changed the API: https://dev.mysql.com/doc/relnotes/mysql/8.3/en/news-8-3-0.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried backporting a commit that claimed to fix the build for mysql 8.3 but it didn't help. Figure it's better to update qt without updating mysql than not updating either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind giving #244 a quick review for the patch. I think I got it right. But as somebody who has already looked at the peticular code path your eyes are very valuable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I don't really understand the changes and wouldn't know how to test it. That's why I gave up trying to patch it and resorted to pinning it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
understood.
webengine attempt: conda-forge/qt-webengine-feedstock#48 |
Typically to merge from main, i check out main
and delete all the rerender commits. That gets rid of 90% of the merge conflicts. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)