Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stricter run_exports #7

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Aug 22, 2022

See RoboStack/ros-humble#6 (comment) for a discussion on why the run_exports should be stricter.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

fyi @danzimmerman

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

Once we merge this, we also need to prepare a repodata patch similar to conda-forge/conda-forge-repodata-patches-feedstock#286 .

@Tobias-Fischer Tobias-Fischer merged commit 47a77c6 into conda-forge:main Aug 22, 2022
@Tobias-Fischer
Copy link
Contributor

Thanks @traversaro!

@Tobias-Fischer
Copy link
Contributor

Are you happy to write the repodata patch as well, @traversaro?

@traversaro
Copy link
Contributor Author

Are you happy to write the repodata patch as well, @traversaro?

Sure! (Self-remainder of how to compute the timestamp: https://github.com/conda/conda-build/blob/84818bc3bbe26f112dfa177f1a49057221599f74/conda_build/metadata.py#L1428)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants