Skip to content

fix: Quote python_version wildcard#2802

Merged
isuruf merged 1 commit intoconda-forge:mainfrom
matthewfeickert:fix/quote-star
Apr 9, 2026
Merged

fix: Quote python_version wildcard#2802
isuruf merged 1 commit intoconda-forge:mainfrom
matthewfeickert:fix/quote-star

Conversation

@matthewfeickert
Copy link
Copy Markdown
Member

@matthewfeickert matthewfeickert commented Apr 8, 2026

Example:

$ git clone git@github.com:conda-forge/contur-feedstock.git && contur-feedstock
$ git diff
diff --git a/recipe/recipe.yaml b/recipe/recipe.yaml
index 5cc7585..ec228f7 100644
--- a/recipe/recipe.yaml
+++ b/recipe/recipe.yaml
@@ -93,7 +93,7 @@ tests:
       pip_check: true
       python_version:
         - ${{ python_min }}.*
-        - "*"
+        - *
   - script:
       - contur --version
       - contur --help
$ pixi run build-locally
...
Error:   × Failed to parse recipe
  ╰─▶ parse error: Failed to parse YAML: 96:11: while scanning an anchor or alias, did not find expected alphabetic or numeric character
   ╭─[/home/conda/recipe_root/recipe.yaml:1:1]
 1 │ schema_version: 1
   · ▲
   · ╰── Failed to parse YAML: 96:11: while scanning an anchor or alias, did not find expected alphabetic or numeric character
 2 │ 
   ╰────

Traceback (most recent call last):
  File "/home/feickert/Code/GitHub/conda-forge/hep-packaging-coordination/contur-feedstock/./build-locally.py", line 125, in <module>
    main()
  File "/home/feickert/Code/GitHub/conda-forge/hep-packaging-coordination/contur-feedstock/./build-locally.py", line 113, in main
    run_docker_build(ns)
  File "/home/feickert/Code/GitHub/conda-forge/hep-packaging-coordination/contur-feedstock/./build-locally.py", line 34, in run_docker_build
    subprocess.check_call([script])
  File "/home/feickert/Code/GitHub/conda-forge/hep-packaging-coordination/contur-feedstock/.pixi/envs/smithy/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['.scripts/run_docker_build.sh']' returned non-zero exit status 1.

PR Checklist:

  • [N/A] note any issues closed by this PR with closing keywords
  • [N/A] if you are adding a new page under docs/ or community/, you have added it to the sidebar in the corresponding _sidebar.json file
  • put any other relevant information below

* If an unquoted wildcard is used for python_version the rattler-build recipe
  will fail.
@matthewfeickert matthewfeickert requested a review from a team as a code owner April 8, 2026 23:28
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 8, 2026

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit d3c2d4d
🔍 Latest deploy log https://app.netlify.com/projects/conda-forge-previews/deploys/69d6e497d57046000848a29b
😎 Deploy Preview https://deploy-preview-2802--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89
Accessibility: 96
Best Practices: 100
SEO: 89
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

python_version:
- ${{ python_min }}.*
- *
- "*"
Copy link
Copy Markdown
Member Author

@matthewfeickert matthewfeickert Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was caught already by @isuruf in #2739 (comment) but somehow this didn't make it into the merged state of PR #2739 as git blame shows that the original file has no quotes.

https://github.com/conda-forge/conda-forge.github.io/blame/c52ebdb725094fd18264c846d15b57b4a92d9cf9/docs/maintainer/example_recipes/pure-python.md#L173

@isuruf isuruf merged commit f9dd23d into conda-forge:main Apr 9, 2026
9 checks passed
@matthewfeickert matthewfeickert deleted the fix/quote-star branch April 9, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants