Fix potential UnicodeDecodeError when reading sidebar JSON files#2800
Merged
beckermr merged 1 commit intoconda-forge:mainfrom Apr 8, 2026
Merged
Fix potential UnicodeDecodeError when reading sidebar JSON files#2800beckermr merged 1 commit intoconda-forge:mainfrom
beckermr merged 1 commit intoconda-forge:mainfrom
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
beckermr
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a potential UnicodeDecodeError when reading sidebar JSON files.
Details
On Windows, Python uses
cp1252as the default encoding when reading files.The sidebar JSON files are UTF-8 encoded, which can lead to decoding errors when using
read_text()without specifying an encoding.This change explicitly sets UTF-8 encoding when reading
_sidebar*.jsonfiles, ensuring consistent cross-platform behavior.Testing
.ci_scripts/check_sidebars.pyruns without encoding issuesNotes
This change aligns with similar encoding fixes in CI scripts and improves reliability across operating systems.