Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msvc package #3666

Draft
wants to merge 2 commits into
base: develop2
Choose a base branch
from
Draft

Conversation

memsharded
Copy link
Member

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite useful! Reads nicely, only 1 wording change

examples/dev_flow/msvc_package.rst Outdated Show resolved Hide resolved
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@czoido czoido modified the milestones: 2.3.0, 2.4.0 May 8, 2024
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good addition!

@czoido czoido marked this pull request as draft May 20, 2024 13:54
@jcar87
Copy link
Contributor

jcar87 commented May 20, 2024

Just a few notes from me:

  • I wouldn't advise renaming C:/Program Files (x86)/Microsoft Visual Studio/2019 to
    C:/Program Files (x86)/Microsoft Visual Studio/2019_2. This breaks a valid installation, and it's a system location. I would advise packaging the installation with the Windows Sandbox and retrieving the Conan package outside of it (conan upload, conan cache save, etc), or alternatively use the command line interface to the visual studio installer and specify an --installPath

  • A working installation of Visual C++ would need access to the Windows SDK (for windows headers and so on) - if I'm not mistaken, those paths would not be copied into the package in the given example, so it is not self-contained

  • CMake seems to use vswhere.exe and query the Windows registry to locate some things (at least the Windows SDK which is not being packaged here) - those may not work.

I'd say this needs more testing - it looks like it only works on a machine that already has visual studio installed

@memsharded
Copy link
Member Author

@czoido czoido modified the milestones: 2.4.0, 2.5.0 Jun 4, 2024
@czoido czoido modified the milestones: 2.5.0, 2.6.0 Jul 2, 2024
@czoido czoido modified the milestones: 2.6.0, 2 Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package visual studio compiler for use with tool_requires
5 participants