[pkgconf] Test requires package in both contexts #7645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
jgsogo
commented
Oct 11, 2021
| @@ -42,8 +43,12 @@ def configure(self): | |||
| del self.settings.compiler.libcxx | |||
| del self.settings.compiler.cppstd | |||
|
|
|||
| def validate(self): | |||
| if hasattr(self, "settings_build") and tools.cross_building(self): | |||
| raise ConanInvalidConfiguration("Cross-building is not implemented in the recipe") | |||
There was a problem hiding this comment.
This is probably because of some missing feature on Meson side. It looks like it is not handling cross-building properly, the log output was:
----Running------
> meson "/Users/jenkins/w/BuildSingleReference@2/.conan/data/pkgconf/1.7.4/_/_/build/30acef53c04f36d5f9412c84a1b3a7434a1f10fb/source_subfolder" "/Users/jenkins/w/BuildSingleReference@2/.conan/data/pkgconf/1.7.4/_/_/build/30acef53c04f36d5f9412c84a1b3a7434a1f10fb/build_subfolder" --backend=ninja -Dprefix="/Users/jenkins/w/BuildSingleReference@2/.conan/data/pkgconf/1.7.4/_/_/package/30acef53c04f36d5f9412c84a1b3a7434a1f10fb" -Dlibdir="lib" -Dbindir="bin" -Dsbindir="bin" -Dlibexecdir="bin" -Dincludedir="include" -Ddefault_library="shared" -Dtests="False" -Dsharedstatedir="/Users/jenkins/w/BuildSingleReference@2/.conan/data/pkgconf/1.7.4/_/_/package/30acef53c04f36d5f9412c84a1b3a7434a1f10fb/bin/share" --buildtype=release
-----------------
The Meson build system
Version: 0.59.2
Source dir: /Users/jenkins/w/BuildSingleReference@2/.conan/data/pkgconf/1.7.4/_/_/build/30acef53c04f36d5f9412c84a1b3a7434a1f10fb/source_subfolder
Build dir: /Users/jenkins/w/BuildSingleReference@2/.conan/data/pkgconf/1.7.4/_/_/build/30acef53c04f36d5f9412c84a1b3a7434a1f10fb/build_subfolder
Build type: native build
Project name: pkgconf
Project version: 1.7.4
source_subfolder/meson.build:1:0: ERROR: Could not invoke sanity test executable: [Errno 86] Bad CPU type in executable: '/Users/jenkins/w/BuildSingleReference@2/.conan/data/pkgconf/1.7.4/_/_/build/30acef53c04f36d5f9412c84a1b3a7434a1f10fb/build_subfolder/meson-private/sanitycheckc.exe'.
There was a problem hiding this comment.
yes, meson build helper does not handle cross compilation at all. conan.tools.meson need to be used, but it currently does not work either, it'll be fixed/improved with conan-io/conan#9710
ericLemanissier
approved these changes
Oct 13, 2021
SSE4
approved these changes
Oct 18, 2021
danimtb
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: ** pkgconf**
It works in Macos for: