Skip to content

Conversation

@trns1997
Copy link
Contributor

@trns1997 trns1997 commented Nov 26, 2025

Summary

Changes to recipe: recipes/pcl/1.14.x

Closes #28985

Motivation

The with_openmp and with_opencv options for the pcl package are not being applied when set via conanfile.txt. Even when explicitly enabling these options, the resulting PCL build behaves as if they are disabled.

Details

Options such as:

pcl/*:with_openmp=True

are ignored during configuration. CMake output confirms that OpenMP and OpenCV support are not enabled, and PCL prints warnings during configuration indicating that OpenMP is disabled.

This change aims to ensure that the option values passed from profiles or conanfile.txt are properly forwarded to the build system and not overwritten in recipe logic (e.g. config_options, configure, or CMake toolchain integration).

Additionally, I discovered that although with_opencv defaults to True in the recipe, OpenCV is never actually enabled nor installed because the current CMake option propagation and dependency checks prevent the condition from ever being met. So even when explicitly enabling with_opencv, the build proceeds without OpenCV support, making the default value misleading and ineffective. Maybe we should consider simplifying this mechanism to prevent confusion?


  • Read the contributing guidelines
  • Checked that this PR is not a duplicate: list of PRs by recipe
  • If this is a bug fix, please link related issue or provide bug details
  • Tested locally with at least one configuration using a recent version of Conan

Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!

@trns1997 trns1997 changed the title make openmp and opencv flag settable pcl/fix with_openmp and with_opencv options not being applied Nov 26, 2025
@jcar87
Copy link
Contributor

jcar87 commented Nov 26, 2025

CMake output confirms that OpenMP and OpenCV support are not enabled, and PCL prints warnings during configuration indicating that OpenMP is disabled.

thanks @trns1997 - could you provide logs both before and after the proposed changes so that we can verify this? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[package] pcl/1.14.1: with_openmp (and couple other options) flags not settable

3 participants