-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpdecimal: Fix lib name on MSVC/shared, fix Mac cross-builds #25889
Merged
jcar87
merged 13 commits into
conan-io:master
from
Ahajha:ahajha/fix-mpdecimal-lib-name
Nov 11, 2024
Merged
mpdecimal: Fix lib name on MSVC/shared, fix Mac cross-builds #25889
jcar87
merged 13 commits into
conan-io:master
from
Ahajha:ahajha/fix-mpdecimal-lib-name
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahajha
changed the title
mpdecimal: Fix lib name on MSVC/shared
mpdecimal: Fix lib name on MSVC/shared, fix Mac cross-builds
Nov 9, 2024
This was referenced Nov 10, 2024
yes please - this makes it a lot easier to review, especially with the size of the backlog - thanks! |
jcar87
reviewed
Nov 11, 2024
jcar87
reviewed
Nov 11, 2024
This reverts commit 90b5587.
jcar87
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
memsharded
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the MSBuildDeps generator with mpdecimal(msvc/shared), it generates the wrong lib name and thus fails to build. I assume CMake does some more advanced logic and so this was never caught.
The correct name is (for example)
libmpdec-2.5.1.dll.lib
, previously this was justlibmpdec-2.5.1.lib
.This change is necessary for supporting shared mpdecimal on Windows in CPython.
Also fixes #23994 (this is fixed by both of my other open mpdecimal PRs, since it's necessary to build. First one to be merged will fix it)
I also have two other mpdecimal PRs out: #25896 #25903 (superset of this one)