Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vorbis: fix MinGW shared + modernize more for conan v2 #20915

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Nov 3, 2023


- add package_type
- use export_conandata_patches
- use rm_safe
- remove CMAKE_POLICY_DEFAULT_CMP0077 workaround (not needed after conan 1.54.0)
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (2a264ce4e13045efe776db979610cd1f1b859ed6):

  • vorbis/1.3.7:
    All packages built successfully! (All logs)

  • vorbis/1.3.6:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (2a264ce4e13045efe776db979610cd1f1b859ed6):

  • vorbis/1.3.7:
    All packages built successfully! (All logs)

  • vorbis/1.3.6:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uilianries uilianries self-assigned this Nov 8, 2023
@conan-center-bot conan-center-bot merged commit 8ec74cb into conan-io:master Nov 8, 2023
19 checks passed
@SpaceIm SpaceIm deleted the fix/vorbis-mingw branch November 8, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants