eastl: add Conan v2 support #17414

valgur · 2023-05-05T21:23:40Z

Specify library name and version: eastl/3.18.00

Depends on #17413 (eabase).

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2023-05-18T13:35:28Z

All committers have signed the CLA.

recipes/eastl/all/conanfile.py

Co-authored-by: Uilian Ries <[email protected]>

uilianries

LGTM

memsharded

Thanks very much for your contribution. However, I think there might be some misunderstading regarding this lib being header-only, I think it is not. I am not sure why this passes, maybe because the test_package contains eastl::max_element only, and that is implemented in the headers and doesn't require any linkage?

recipes/eastl/all/conanfile.py

github-actions · 2023-06-18T14:23:08Z

Hooks produced the following warnings for commit 416b745

eastl/3.16.01

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libEASTL.so' links to system library 'm' but it is not in cpp_info.system_libs.

eastl/3.16.05

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libEASTL.so' links to system library 'm' but it is not in cpp_info.system_libs.

eastl/3.16.07

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libEASTL.so' links to system library 'm' but it is not in cpp_info.system_libs.

eastl/3.15.00

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libEASTL.so' links to system library 'm' but it is not in cpp_info.system_libs.

eastl/3.18.00

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libEASTL.so' links to system library 'm' but it is not in cpp_info.system_libs.

eastl/3.17.06

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libEASTL.so' links to system library 'm' but it is not in cpp_info.system_libs.

eastl/3.17.03

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libEASTL.so' links to system library 'm' but it is not in cpp_info.system_libs.

uilianries · 2023-06-19T06:28:04Z

@memsharded good catch! thanks for reviewing it!

SSE4 · 2023-06-27T07:02:14Z

max_element

@memsharded max_element is template function, thus it's implemented in header file (it obviously cannot be implemented in .cpp, because of template parameter). therefore, it only needs a header file and doesn't require any linkage.
now with your question answered, could you possibly unblock review?

conan-center-bot · 2023-06-28T15:51:46Z

Conan v1 pipeline ✔️

All green in build 11 (4a6561eec40a507fa39af10fbf9149fba992be91):

eastl/3.18.00@:
All packages built successfully! (All logs)
eastl/3.16.05@:
All packages built successfully! (All logs)
eastl/3.16.07@:
All packages built successfully! (All logs)
eastl/3.15.00@:
All packages built successfully! (All logs)
eastl/3.17.06@:
All packages built successfully! (All logs)
eastl/3.17.03@:
All packages built successfully! (All logs)
eastl/3.16.01@:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 8 (4a6561eec40a507fa39af10fbf9149fba992be91):

eastl/3.18.00@:
All packages built successfully! (All logs)
eastl/3.16.01@:
All packages built successfully! (All logs)
eastl/3.17.06@:
All packages built successfully! (All logs)
eastl/3.17.03@:
All packages built successfully! (All logs)
eastl/3.16.05@:
All packages built successfully! (All logs)
eastl/3.16.07@:
All packages built successfully! (All logs)
eastl/3.15.00@:
All packages built successfully! (All logs)

SSE4 · 2023-06-30T07:17:56Z

@memsharded ping

uilianries

LGTM

uilianries · 2023-06-30T07:31:50Z

recipes/eastl/all/conanfile.py


    def requirements(self):
-        self.requires("eabase/2.09.06")
+        self.requires("eabase/2.09.12", transitive_headers=True)


Okay, we will have the follow error in case is not exposed:

p/include/EASTL/internal/config.h:61:11: fatal error: 'EABase/eabase.h' file not found #include <EABase/eabase.h>

uilianries · 2023-06-30T07:35:07Z

I just started a new CI job for Conan v2, as it failed but was an internal error.

question resolved

* eastl: add Conan v2 support * eastl: specify supported minimum compiler versions * eastl: fix copying of licenses * eastl: remove unnecessary transitive_*=True * eastl: drop test_v1_package * eastl: set CMAKE_CXX_STANDARD Co-authored-by: Uilian Ries <[email protected]> * eastl: revert minimum compiler versions * eastl: test against the non-header-only part of eastl * eastl: convert recipe from header-only to library * eastl: add required `operator new[]()` to test_package.cpp * eastl: add 'm' to system_libs --------- Co-authored-by: Uilian Ries <[email protected]>

eastl: add Conan v2 support

ea0dbd0

valgur marked this pull request as draft May 5, 2023 21:23

conan-center-bot added the Failed label May 5, 2023

This comment has been minimized.

Sign in to view

valgur closed this May 9, 2023

valgur reopened this May 9, 2023

valgur marked this pull request as ready for review May 9, 2023 15:07

This comment has been minimized.

Sign in to view

valgur marked this pull request as draft May 9, 2023 18:42

valgur added 2 commits May 10, 2023 14:15

eastl: specify supported minimum compiler versions

3ffd7c0

eastl: fix copying of licenses

92f59c1

This comment has been minimized.

Sign in to view

conan-center-bot removed the Failed label May 10, 2023

This comment has been minimized.

Sign in to view

valgur marked this pull request as ready for review May 11, 2023 06:49

prince-chrismc mentioned this pull request May 11, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

memsharded previously approved these changes May 25, 2023

View reviewed changes

recipes/eastl/all/conanfile.py Outdated Show resolved Hide resolved

valgur added 2 commits May 25, 2023 13:22

eastl: remove unnecessary transitive_*=True

12bf1a3

eastl: drop test_v1_package

7f825dc

valgur dismissed memsharded’s stale review via 7f825dc May 25, 2023 10:23

valgur requested a review from memsharded May 25, 2023 10:33

This comment has been minimized.

Sign in to view

uilianries reviewed Jun 5, 2023

View reviewed changes

recipes/eastl/all/conanfile.py Outdated Show resolved Hide resolved

uilianries reviewed Jun 7, 2023

View reviewed changes

recipes/eastl/all/conanfile.py Show resolved Hide resolved

valgur and others added 2 commits June 7, 2023 13:55

eastl: set CMAKE_CXX_STANDARD

da9d043

Co-authored-by: Uilian Ries <[email protected]>

eastl: revert minimum compiler versions

4ea2dcc

This comment has been minimized.

Sign in to view

uilianries previously approved these changes Jun 7, 2023

View reviewed changes

memsharded previously requested changes Jun 16, 2023

View reviewed changes

recipes/eastl/all/conanfile.py Outdated Show resolved Hide resolved

recipes/eastl/all/conanfile.py Outdated Show resolved Hide resolved

recipes/eastl/all/conanfile.py Outdated Show resolved Hide resolved

valgur added 3 commits June 18, 2023 14:50

eastl: test against the non-header-only part of eastl

682547e

eastl: convert recipe from header-only to library

c865fa3

eastl: add required operator new[]() to test_package.cpp

416b745

valgur dismissed uilianries’s stale review via 416b745 June 18, 2023 12:26

This comment has been minimized.

Sign in to view

eastl: add 'm' to system_libs

4a6561e

valgur requested review from memsharded and uilianries June 18, 2023 19:48

This comment has been minimized.

Sign in to view

conan-center-bot added the Unexpected Error label Jun 22, 2023

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Jun 26, 2023

Change approvals to include reviewer tier prince-chrismc/conan-center-index-pending-review#130

Merged

conan-center-bot removed the Unexpected Error label Jun 28, 2023

uilianries self-assigned this Jun 30, 2023

uilianries approved these changes Jun 30, 2023

View reviewed changes

AbrilRBS removed the request for review from memsharded June 30, 2023 10:11

toge approved these changes Jul 2, 2023

View reviewed changes

SSE4 approved these changes Jul 2, 2023

View reviewed changes

conan-center-bot merged commit c565c30 into conan-io:master Jul 2, 2023
5 checks passed

valgur deleted the eastl branch July 2, 2023 15:10

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

eastl: add Conan v2 support #17414

eastl: add Conan v2 support #17414

valgur commented May 5, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

CLAassistant commented May 18, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

uilianries left a comment

memsharded left a comment

This comment has been minimized.

github-actions bot commented Jun 18, 2023

This comment has been minimized.

uilianries commented Jun 19, 2023

This comment has been minimized.

SSE4 commented Jun 27, 2023

conan-center-bot commented Jun 28, 2023

SSE4 commented Jun 30, 2023

uilianries left a comment

uilianries Jun 30, 2023

uilianries commented Jun 30, 2023

eastl: add Conan v2 support #17414

eastl: add Conan v2 support #17414

Conversation

valgur commented May 5, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

CLAassistant commented May 18, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

uilianries left a comment

Choose a reason for hiding this comment

memsharded left a comment

Choose a reason for hiding this comment

This comment has been minimized.

github-actions bot commented Jun 18, 2023

This comment has been minimized.

uilianries commented Jun 19, 2023

This comment has been minimized.

SSE4 commented Jun 27, 2023

conan-center-bot commented Jun 28, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

SSE4 commented Jun 30, 2023

uilianries left a comment

Choose a reason for hiding this comment

uilianries Jun 30, 2023

Choose a reason for hiding this comment

uilianries commented Jun 30, 2023

valgur commented May 5, 2023 •

edited

Loading

CLAassistant commented May 18, 2023 •

edited

Loading