fix: #87 update query and context display #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the selected query has the same query but different context as described in issue comunica#87 the context would not update. with this additional check to see if the context differs as well both get updated
|
|
|
Nice! For queries that do not have a context (e.g. regular SPARQL queries), does everything still work as expected? |
|
yes, I tested all the other queries and they all work. |
|
Looks perfect @milafrerichs, thanks! Feel free to submit an invoice to our open collective page. (or you can also bundle it when the other bounty has been completed if you'd prefer that) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if the selected query has the same query but different context as described in issue #87 the context would not update.
with this additional check to see if the context differs as well both get updated
How to reproduce:
use the queries from this repository (from the issue creator):
https://github.com/KasperZutterman/datascience-comunica-client/tree/master/queries/kadaster
and test the buurt-in-gemeente-reverse and buurt-in-gemeente queries