This repository has been archived by the owner on Feb 19, 2024. It is now read-only.
Updated repo.pp to only install repo key if it is not already installed #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified exec{"apt_key_add_${normalized_name}":} for Debian installations to get the gpg key fingerprint of the repository and only add it if a key with the same fingerprintdoes not exist locally.
ice799
reviewed
Mar 8, 2017
| } | ||
|
|
||
| exec { "apt_get_update_${normalized_name}": | ||
| command => "apt-get update -o Dir::Etc::sourcelist=\"sources.list.d/${normalized_name}.list\" -o Dir::Etc::sourceparts=\"-\" -o APT::Get::List-Cleanup=\"0\"", | ||
| path => '/usr/bin/:/bin/', | ||
| require => Exec["apt_key_add_${normalized_name}"], | ||
| refreshonly => true, |
There was a problem hiding this comment.
I'm not sure adding a refreshonly here will work. A lot of our users re-run their puppet configs as part of CI/CD pipeline and would expect the latest repository metadata to get pulled in. I think adding a refresh only here would prevent that update from happening.
|
Hi! Thanks for sending this PR @palintir! The changes look fine to me except the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified exec{"apt_key_add_${normalized_name}":} for Debian installations to get the gpg key fingerprint of the repository and only add it if a key with the same fingerprintdoes not exist locally.