Skip to content

Upload the VS Installer log #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

Steelskin
Copy link
Collaborator

Rather than dumping the log to the bot output, the log file is now uploaded as an artifact named after the job name.

Rather than dumping the log to the bot output, the log file is now
uploaded as an artifact named after the job name.
@Steelskin Steelskin requested a review from compnerd May 30, 2025 16:09
@Steelskin
Copy link
Collaborator Author

Steelskin commented May 30, 2025

@compnerd Here, I am uploading the log file unconditionally because I figured it might be handy to have successful logs on hand to compare with the bad ones. This is why we need a prefix to differentiate between the different jobs and matrices. Unfortunately, GitHub does not provide an easy API to get a unique job ID.

Let me know if you'd rather we only upload on failure.

@compnerd
Copy link
Owner

${{ github.job }} should get you the name of the job itself. However, I think that it is better if we just limit to uploading on failure.

@Steelskin
Copy link
Collaborator Author

${{ github.job }} should get you the name of the job itself. However, I think that it is better if we just limit to uploading on failure.

The problem with ${{ github.job }} is that it does not provide a unique name with matrix jobs. I have changed this to only upload on failure.

@Steelskin Steelskin merged commit e70a455 into main May 30, 2025
5 checks passed
@Steelskin Steelskin deleted the fabrice/setup-build-action-log-output-file branch May 30, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants