-
Notifications
You must be signed in to change notification settings - Fork 31
Moving code coverage from ubuntu-arm to ubuntu-x86 #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was requested as apparantly opp only works ob Ubuntu x86 (still waiting to hear why). It makes more sense to me to move coverage to the oop job in that PR.
The reason why it works for ub-x86 and not ub-arm, is because the LLVM side of code does not handle the ub-arm case. There might be some issues with ubuntu-arm supporting, that we might not know. if (SystemTriple.isOSBinFormatELF())
OrcRuntimePath =
BasePath.str().str() + "/lib/x86_64-unknown-linux-gnu/liborc_rt.a";
else if (SystemTriple.isOSBinFormatMachO())
OrcRuntimePath = BasePath.str().str() + "/lib/darwin/liborc_rt_osx.a";
else
return llvm::make_error<llvm::StringError>(
"Out-of-process execution is not supported on non-unix platforms",
llvm::inconvertibleErrorCode()); [EDIT] Seems like it only creates these
|
This stands discussed in an internal channel between GSoC mentors (me, Vipul, Vassil) and our mentee (Abhinav) . Currently Abhinav plans on running tests 3 times in the oop build
And we would need to switch to ubuntu-x86 for code coverage |
@mcbarton And regarding moving it to x86 machine:
while running coverage on x86. Does there is some cache that codecov uses? Because it might be matching our source code(in x86) with something that has been cached in previous runs(in arm). Check this out
lcov: ERROR: 'exclude' pattern '/home/runner/.cache/*' is unused.
(use "lcov --ignore-errors unused ..." to bypass this error) This kind of proves that codecov does uses some kind of cache. Do we need to delete some files before running these coverage tests on x86? |
I still thinks best to switch to ubuntu x86 on the oop PR. Otherwise you'll end up switching it to a non oop job here, and then probably have to switch it to a opp job in that PR anyway. @kr-2003 You do not need to delete any file to switch the coverage. As far as how to get past that error I do not know off the top of my head. I know it doesn't have anything specific to do with changing to x86. This error has come up before, and is the reason the old coverage job is on a Ubuntu 22.04 runner (I was too lazy previously to work out why I got this error on a Ubuntu 24.04, since it didn't impede any other work). |
Ok |
@kr-2003 could you rebase this branch with master? If not already done. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 79.18% 79.18%
=======================================
Files 9 9
Lines 3853 3853
=======================================
Hits 3051 3051
Misses 802 802 🚀 New features to boost your workflow:
|
Description
This PR makes the code coverage using the ubuntu's x86 machine instead of using arm machine.
Type of change
Checklist