Skip to content

[wip] Remove cling 1.0 support + Make llvm 16 minimum version #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

This PR will remove support for cling 1.0 from CppInterOp, and make the minimum version of llvm supported as 16.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton changed the title Remove cling 1.0 support + Make llvm 16 minimum version [wip] Remove cling 1.0 support + Make llvm 16 minimum version May 19, 2025
@mcbarton mcbarton marked this pull request as draft May 19, 2025 12:11
@mcbarton
Copy link
Collaborator Author

The workflows of this PR are expected to fail for cling jobs until #580 is in. Once I have checked that all clang-repl jobs work still pass I will move onto refining compatibility.h which can now have some parts removed.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.43%. Comparing base (951775f) to head (6327123).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #581   +/-   ##
=======================================
  Coverage   76.43%   76.43%           
=======================================
  Files           9        9           
  Lines        3666     3666           
=======================================
  Hits         2802     2802           
  Misses        864      864           
Files with missing lines Coverage Δ
lib/Interpreter/Compatibility.h 91.96% <ø> (ø)
lib/Interpreter/CppInterOp.cpp 84.33% <ø> (ø)
Files with missing lines Coverage Δ
lib/Interpreter/Compatibility.h 91.96% <ø> (ø)
lib/Interpreter/CppInterOp.cpp 84.33% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton mcbarton mentioned this pull request May 20, 2025
4 tasks
@mcbarton mcbarton force-pushed the Remove-cling-1.0-support branch from 3ed229b to 3327c5f Compare May 22, 2025 13:33
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton mcbarton force-pushed the Remove-cling-1.0-support branch from c0ca01c to 0eb9faa Compare May 23, 2025 10:58
@mcbarton mcbarton force-pushed the Remove-cling-1.0-support branch from 0eb9faa to 6327123 Compare May 23, 2025 10:59
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant