Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native_aarch64 install option #1267

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add native_aarch64 install option #1267

wants to merge 3 commits into from

Conversation

partouf
Copy link
Member

@partouf partouf commented Apr 8, 2024

Way to install aarch64 binaries under amd64 (doesn't execute the version check)
bin/ce_install --enable native_aarch64 --only-native-aarch64 install ...

Side-effect: will say things are already installed when they don't fall under the if: native_aarch64 without actually checking

Copy link
Member

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be easier to support a --only=blah that generally fixes this for if: checks. We might not be able to use that for nightly as it's a bit hacky (though, maybe not?) but...seems like we'll end up with a lot of other matches if we're not careful if/when we support other platforms.

not blocking at all, don't want to stop forward progress, but thinking out loud here

@@ -148,6 +148,7 @@ def squash_mount_check(rootfolder, subdir, context):
)
@click.option("--enable", metavar="TYPE", multiple=True, help='Enable targets of type TYPE (e.g. "nightly")')
@click.option("--only-nightly", is_flag=True, help="Only install the nightly targets")
@click.option("--only-native-aarch64", is_flag=True, help="Only install the Native Aarch64 targets")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we probably need a more general --only if we need to start adding lots of these.

@@ -109,6 +109,9 @@ def should_install(self) -> bool:
if self.install_context.only_nightly and not self.nightly_like:
return False

if self.install_context.only_native_aarch64 and self.config_get("if", "") != "native_aarch64":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pragmatic, but I can't help wondering if a more general --only=native_aarch64 would be easier and more extensible. The nightly flag is special as we heuristically guess it rather than it being an actual if check in some cases

Copy link
Member Author

@partouf partouf May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--only=... is not possible, i have experimented with it, but it breaks all the dependency handling and whatnot

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be exactly the same as what you have there? Like..

if self.install_context.only and self.config_get("if", "") != self.install_context.only:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see that way, hmm, maybe. I experimented with making the filter do the work with narrowing the selection, but it's very hard to work with that code in general because the if information is not complete there like it is with config_get().

I'll give it a try

@partouf partouf marked this pull request as draft May 29, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants