Class #49

[Ayato0404]

This change is

[shundroid]

Review status: 0 of 13 files reviewed at latest revision, 3 unresolved discussions.

---

js/canvas-model.js, line 9 [r2] (raw file):
コメントが消えちゃっているので、getImageData()に追加してください。

---

js/drawing-configuration.js, line 33 [r2] (raw file):
行末にスペースが２つ入っているっぽいので、修正よろしくお願いします！

---

js/frames-controller.js, line 7 [r2] (raw file):
constructorの引数が抜けているので追加してください！
インデントの修正もおねがいします

---

Comments from Reviewable

[shundroid]

Reviewed 1 of 13 files at r2.
Review status: 1 of 13 files reviewed at latest revision, 3 unresolved discussions.

---

Comments from Reviewable

[shundroid]

Review status: 1 of 13 files reviewed at latest revision, 4 unresolved discussions.

---

js/paint-manager.js, line 6 [r2] (raw file):
ここも引数で、element を渡してください

---

Comments from Reviewable

[shundroid]

Review status: 1 of 13 files reviewed at latest revision, 6 unresolved discussions.

---

js/paint-manager.js, line 44 [r2] (raw file):
ここも引数でevent

---

js/paint-manager.js, line 58 [r2] (raw file):
ここも

---

Comments from Reviewable

[shundroid]

Review status: 1 of 13 files reviewed at latest revision, 13 unresolved discussions.

---

js/player.js, line 12 [r2] (raw file):
ここも

---

js/player.js, line 28 [r2] (raw file):
ここも

---

js/publisher.js, line 7 [r2] (raw file):
ここと

---

js/publisher.js, line 14 [r2] (raw file):
ここ

---

js/view-manager.js, line 9 [r2] (raw file):
ここ

---

js/view/color-picker-view.js, line 4 [r2] (raw file):
ここ

---

js/view/color-picker-view.js, line 19 [r2] (raw file):
ここ

---

Comments from Reviewable

[shundroid]

Review status: 1 of 13 files reviewed at latest revision, 15 unresolved discussions.

---

js/view/color-picker-view.js, line 3 [r2] (raw file):
全部小文字になっています

---

js/view/color-picker-view.js, line 40 [r2] (raw file):
この isColor に関してですが、class にしないで関数のままでおねがいします。
関数をclassとしているものと、関数のままでいいものを見分けるものとして、
「名前の最初が大文字か」があります。
ColorPickerViewのように、大文字で始まっているものは、classにしてください。

---

Comments from Reviewable

[shundroid]

Review status: 1 of 13 files reviewed at latest revision, 16 unresolved discussions.

---

js/view/line-width-picker-view.js, line 3 [r2] (raw file):
Panelと{
間にスペースをおねがいします。

---

Comments from Reviewable

[shundroid]

Review status: 1 of 13 files reviewed at latest revision, 19 unresolved discussions.

---

js/view/line-width-picker-view.js, line 4 [r2] (raw file):
引数でelemを渡してください

---

js/view/line-width-picker-view.js, line 14 [r2] (raw file):
ここ

---

js/view/line-width-picker-view.js, line 19 [r2] (raw file):
ここも

---

Comments from Reviewable

[shundroid]

Review status: 1 of 13 files reviewed at latest revision, 26 unresolved discussions.

---

js/view/menu-view.js, line 31 [r2] (raw file):
ここも引数

---

js/view/menu-view.js, line 42 [r2] (raw file):
ここも引数

---

js/view/menu-view.js, line 50 [r2] (raw file):
ここも

---

js/view/player-view.js, line 4 [r2] (raw file):
ここも引数

---

js/view/sequence-view.js, line 4 [r2] (raw file):
ここもお願いします

---

js/view/sequence-view.js, line 66 [r2] (raw file):
ここも

---

js/view/sequence-view.js, line 84 [r2] (raw file):
ここも

---

Comments from Reviewable

[shundroid]

Review status: 1 of 13 files reviewed at latest revision, 24 unresolved discussions, some commit checks failed.

---

js/frames-controller.js, line 7 [r2] (raw file):

Previously, shundroid wrote…

constructorの引数が抜けているので追加してください！
インデントの修正もおねがいします

インデントの修正もおねがいしますー

---

Comments from Reviewable

[shundroid]

Review status: 1 of 13 files reviewed at latest revision, 17 unresolved discussions, some commit checks failed.

---

js/view/color-picker-view.js, line 19 [r2] (raw file):

Previously, shundroid wrote…

ここ

) が 1つ多いです。

---

Comments from Reviewable