Various unrelated fixes to kimai update script #4549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 4548
|
I can think of a few other ways to do the test, this was just the first thing I thought of. Not sure if there's a standard way to do this. |
There's a proposed solution to community-scripts#4247 (which doesn't seem to have been committed - I'll fix that in a moment). I've changed the test I'm using to match that suggestion.
jamezpolley
changed the title
During troubleshooting of another error, I ran into a condition where downloading the new version failed. It seems that this is because the earlier call to get the $RELEASE had failed. This change is an attempt to catch download errors, and alert the user, and to not rm the existing install until we know the download worked.
I missed in the earlier commit that this wasn't getting reinstalled
|
I was finally able to get the new version of kimai working - but only after manually undoing and redoing various steps of this upgrade. In particular, the finall step (reinstall php-fpm) was done by hand after everything else had run. So I can't say that I've tested this script as thoroughly as I would like. |
MickLesk
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aren't related but have been merged into #4548 as per directions from project owners, sorry.
✍️ Description
Various unrelated fixes
🔗 Related PR / Issue
Link: #4548 and #4247 and #4550
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.