Rephrase the string copy_image_caption_description #6472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/res/values/strings.xml
Outdated
| <string name="images_via_nearby_explanation">Images Uploaded via Nearby places are the images which are uploaded by discovering places on the map.</string> | ||
| <string name="thanks_received_explanation">This feature allows editors to send a Thank you notification to users who make useful edits – by using a small thank link on the history page or diff page.</string> | ||
| <string name="copy_image_caption_description">Copy to subsequent media</string> | ||
| <string name="copy_image_caption_description">Copy to the next item</string> |
There was a problem hiding this comment.
The button actually copies to all of the remaining items after that one.
I feel that the meaning could be improved.
There was a problem hiding this comment.
Thanks! I should have thought of that. I changed it to "items". Is it better?
I was going over all the strings and documenting them (see commons-app#6457), and I had a very hard time understand what this message does. I read the code and finally figured it out. I added qq documentation for it so now it's clearer, but I also think that the English message can be clearer: * "subsequent" changed to "the next" - shorter, easier word. * "media" changed to "item" - "media" could mean a lot of things, and "item" is clearer in this context.
|
✅ Generated APK variants! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
I was going over all the strings and documenting them (see #6457), and I had a very hard time understand what this message does. I read the code and finally figured it out. I added qq documentation for it so now it's clearer, but I also think that the English message can be clearer:
Tests performed (required)
Checked in the emulator in Android Studio.