Change filename to username in toasts about sending thanks #6467
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes commons-app#6466. Also fix the messages themselves a bit: * Removed "successfully" from the success message. This word is usually redundant, because the message already says that it was done. (In MediaWiki, there's a specific convention about it: https://www.mediawiki.org/wiki/Help:System_message#Avoid_jargon_and_slanghttps://www.mediawiki.org/wiki/Help:System_message#Avoid_jargon_and_slang ) * Added a missing preposition to the failure message.
|
✅ Generated APK variants! |
|
I just tested. Not sure how to simulate an error, with no Internet the button does not react. But otherwise it works, so I assume both should be OK. |
|
Yeah, I think it makes sense that it's "for" in one message and "to" in the others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6466.
Also fix the messages themselves a bit:
Till now, I've made a bunch of rather trivial localization fixes in this repo, but this is the first time I'm sending actual Kotlin code, so please:
Tests performed (required)
I ran it in the emulator in Android Studio, sent thanks to a user, and it appeared with the correct username.