-
-
Notifications
You must be signed in to change notification settings - Fork 310
fix(git): commit bodies with carriage returns are correctly split by … #1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(git): commit bodies with carriage returns are correctly split by … #1780
Conversation
…line This should enable us to correctly parse squashed commits made on an SCM server residing on a Windows OS.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1780 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 60 60
Lines 2606 2606
=======================================
Hits 2551 2551
Misses 55 55 ☔ View full report in Codecov by Sentry. |
bearomorphism
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good, but I noticed a small inconsistency between the test and the implementation
bearomorphism
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@woile @Lee-W @noirbizarre could you also take a look?
... line
This should enable us to correctly parse squashed commits made on an SCM server residing on a Windows OS.
Description
Checklist
Code Changes
uv run poe alllocally to ensure this change passes linter check and testsDocumentation Changes
uv run poe doclocally to ensure the documentation pages renders correctlyExpected Behavior
Commit bodies that use carriage returns for line breaks will now be successfully split when getting processed. In particular this enables commitizen to process squash commits made on an SCM server that is hosted by a Windows OS.
Steps to Test This Pull Request
\r\n):cz changelog --dry-runand verify that only thefeatandfixentries are included\n)cz changelog --dry-runand verify that only thefeatandfixentries are includedAdditional Context