Jump to specific event in timeline #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #243 , but wont close it yet as it currently only works if we want to jump to an even that is already loaded in current timeline. If the event is not yet loaded, this is a separate case which needs to be handled differently |
works by rendering entire timeline offscreen and measuring offset to desired event
Airyzz
force-pushed
the
feat/jump-to-event
branch
from
cb7e36e to
cc0eb81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works by rendering entire timeline offscreen and measuring offset to desired eventCame up with a way more elegant solution: by manipulating the display indices of events in the timeline, we can force an arbitrary event to be positioned at the center of the scroll view. Because of this, we can always assume that the event will begin at scroll position
0.0and so we can simply scroll to0 + viewHeight/2to end up with the event positioned in the center of the viewSuper happy with this approach!