Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5925 Add file-watch-hook for post-processing #6597

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Fix #5925 Add file-watch-hook for post-processing #6597

merged 1 commit into from
Jun 30, 2024

Conversation

mpilgrem
Copy link
Member

@mpilgrem mpilgrem commented Jun 1, 2024

  • Any changes that could be relevant to users have been recorded in ChangeLog.md.
  • The documentation has been updated, if necessary

Please also shortly describe how you tested your change. Bonus points for added tests!

This is draft while testing on different operating systems.

@mpilgrem mpilgrem marked this pull request as draft June 1, 2024 23:10
@mpilgrem
Copy link
Member Author

mpilgrem commented Jun 2, 2024

--file-watch is now misbehaving. I think this because I lifted the withConfig up out of the inner (because fileWatchConf itself needed access to the file-watch-hook configuration). I'll reverse that.

@mpilgrem mpilgrem force-pushed the fix5925 branch 2 times, most recently from 4f6fe19 to 4ce9693 Compare June 3, 2024 22:32
@mpilgrem mpilgrem marked this pull request as ready for review June 3, 2024 22:42
@mpilgrem mpilgrem merged commit 6b26526 into master Jun 30, 2024
14 checks passed
@mpilgrem mpilgrem deleted the fix5925 branch June 30, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant