Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6558 Spring clean wiredInPackages #6559

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Fix #6558 Spring clean wiredInPackages #6559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .stan.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,16 +177,16 @@

# Anti-pattern: unsafe functions
[[ignore]]
id = "OBS-STAN-0212-5rtOmw-486:33"
id = "OBS-STAN-0212-5rtOmw-482:33"
# ✦ Description: Usage of unsafe functions breaks referential transparency
# ✦ Category: #Unsafe #AntiPattern
# ✦ File: src\Stack\Constants.hs
#
# 481 ┃
# 482 ┃ setupGhciShimCode = byteString $(do
# 483 ┃ path <- makeRelativeToProject "src/setup-shim/StackSetupShim.hs"
# 484 ┃ embedFile path)
# 485 ┃
# 486 ┃ setupGhciShimCode = byteString $(do
# 487 ┃ path <- makeRelativeToProject "src/setup-shim/StackSetupShim.hs"
# 488 ┃ embedFile path)
# 489 ┃

# Anti-pattern: unsafe functions
[[ignore]]
Expand Down
30 changes: 13 additions & 17 deletions src/Stack/Constants.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,34 +254,30 @@ wiredInPackages = case mparsed of
Nothing -> impureThrow WiredInPackagesNotParsedBug
where
mparsed = mapM parsePackageName
[ "ghc-prim"
[ "rts"
-- Said to be not a \'real\' package
, "ghc-prim"
-- A magic package
, "ghc-bignum"
-- A magic package
, "integer-gmp"
-- No longer magic > 1.0.3.0. With GHC 9.6.4 at least, there seems to be
-- no problem in using it.
-- No longer magic > 1.0.3.0 (GHC >= 9.0) and deprecated in favour of
-- ghc-bignum. With GHC 9.6.4 at least, there seems to be no problem in
-- using it.
, "integer-simple"
-- A magic package
, "base"
-- A magic package
, "rts"
-- Said to be not a \'real\' package
, "template-haskell"
-- A magic package
, "dph-seq"
-- Deprecated in favour of dph-prim-seq, which does not appear to be
-- magic. With GHC 9.6.4 at least, there seems to be no problem in using
-- it.
, "dph-par"
-- Deprecated in favour of dph-prim-par, which does not appear to be
-- magic. With GHC 9.6.4 at least, there seems to be no problem in using
-- it.
, "ghc"
-- A magic package
, "interactive"
chreekat marked this conversation as resolved.
Show resolved Hide resolved
-- Could not identify information about this package name. With GHC 9.6.4
-- at least, there seems to be no problem in using it.
, "ghc-bignum"
-- A magic package
-- Type and class declarations at the GHCi command prompt are treated as
-- if they were defined in modules all sharing a common package
-- interactive. See 'Note [The interactive package]' at
-- https://gitlab.haskell.org/ghc/ghc/-/blob/master/compiler/GHC/Runtime/Context.hs
-- With GHC 9.6.4 at least, there seems to be no problem in using it.
]

-- | Just to avoid repetition and magic strings.
Expand Down