refactoring: put installed stuff into a dedicated types package #6357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theobat
force-pushed
the
installed-refactoring
branch
from
541f6c5 to
30f56e0
Compare
|
I think the integration tests are failing because you have edited the |
|
The self-hosted runner for Linux ARM64 is not picking up (it has been a problem for a couple of days). I'll ask Michael Snoyman to look into it (it has happened before). |
theobat
force-pushed
the
installed-refactoring
branch
from
30f56e0 to
3dd464d
Compare
|
@mpilgrem I fixed it thanks, it's only missing the ARM64 now |
mpilgrem
force-pushed
the
installed-refactoring
branch
from
401914a to
e2ca123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it's not going to stay a "Package" thing in the future if we build at the component level