-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config get and dump commands. #5835
base: master
Are you sure you want to change the base?
Add config get and dump commands. #5835
Conversation
@philderbeast, given your request to not merge yet, I changed the status of the pull request to 'draft'. |
I've now got the order preserved in the YAML and also display the JSON in a human-readable layout also with field order preserved:
|
Get the project resolver. Add config get commands. Get project system-ghc and install-ghc. Extract duplicated as logBool. Show scope. Don't log the key asked for. Should have been NoReexec. Get and Modify variants of scopeFlag help. Dump the project's configuration. Pipe to common functions for config list. Add scope and distinguish what is being dumped. Extract encodeDump* functions. First pass at dump-project and dump-stack. Separate project and stack dumps more. Add DumpStackScope and --lens option. Parse what is needed for the dump. Fix typos and improve help string. Allow for missing stack settings in the project. Fix a typo, aronud. Better explain effective scope. Drop the --global option when dumping the project.
0830fbc
to
92d3141
Compare
@philderbeast, I see the CI is passing. If this is no longer 'draft', the 'Ready for review' button will turn off draft status. |
I've been thinking about your proposed new commands. We have the existing You propose to introduce It seemed to me that the proposed
On terminology, Stack's online documentation distinguishes between 'project-specific' options and 'non-project specific' options (the latter in either a 'project-level' YAML configuration file or a 'global' YAML configuration file). I think it is fine to call non-project specific options 'global options', for short. |
@mpilgrem when I chose |
@philderbeast, similar to my posts elsewhere, letting you know that I will release a new version of Stack soon, if you want to bring this pull request to a conclusion. |
See #5600.
Please don't merge yet as I would like to preserve the order of the fields when dumping the project as YAML.