Merge pull request #6552 from commercialhaskell/fix6551

Fix #6551 Use action `getLatestApplicableVersionAndRev` only when needed

ChangeLog.md

@@ -56,6 +56,8 @@ Bug fixes:
 
 * The `config set snapshot` and `config set resolver` commands now respect the
   presence of a synoymous key.
+* Fix a regression introduced in Stack 2.15.1 that caused a 'no operation'
+  `stack build` to be slower than previously.
 
 ## v2.15.5 - 2024-03-28
 

src/Stack/Build/ConstructPlan.hs

@@ -829,7 +829,6 @@ processDep ::
            MissingPresentDeps
        )
 processDep pkgId name value = do
-  mLatestApplicable <- getLatestApplicableVersionAndRev name range
   eRes <- getCachedDepOrAddDep name
   let failure mLatestApp err =
         Left $ Map.singleton name (range, mLatestApp, err)
@@ -844,17 +843,19 @@ processDep pkgId name value = do
             -- spamming the user too much.
             DependencyPlanFailures _ _  ->
               Couldn'tResolveItsDependencies version
+      mLatestApplicable <- getLatestApplicableVersionAndRev name range
       pure $ failure mLatestApplicable bd
     Right adr
       | isDepTypeLibrary value.depType && not (adrHasLibrary adr) ->
           pure $ failure Nothing HasNoLibrary
     Right adr -> do
       addParent
       inRange <- adrInRange pkgId name range adr
-      pure $ if inRange
-        then Right $ processAdr adr
-        else failure mLatestApplicable (DependencyMismatch $ adrVersion adr)
-
+      if inRange
+        then pure $ Right $ processAdr adr
+        else do
+          mLatestApplicable <- getLatestApplicableVersionAndRev name range
+          pure $ failure mLatestApplicable (DependencyMismatch $ adrVersion adr)
  where
   range = value.versionRange
   version = pkgVersion pkgId